Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/build-angular): prepare for Vite 5 #25634

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

benmccann
Copy link
Contributor

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

require the CJS version of Vite

Issue Number: N/A

What is the new behavior?

import the ESM version of Vite. Vite will soon be deprecating or removing the CJS build

Angular CLI should probably be published as ESM. That will almost certainly be necessary in the long-term as more an more packages switch to ESM only. Such a change would be invisible to users since the engines field already specifies compatible versions of Node. However, that's a larger change and I'm probably not the right person to make such a change

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

ESM output is planned for the CLI packages. However, several build infrastructure updates are required first. Additionally, it may be breaking for some downstream programmatic usages of the CLI packages.

@clydin clydin added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Aug 4, 2023
@clydin clydin merged commit e4b7c02 into angular:main Aug 4, 2023
22 checks passed
@benmccann benmccann deleted the esm branch August 4, 2023 20:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants