fix(@angular-devkit/build-angular): update vite to be able to serve app-shell and SSG pages #25653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
ssr-prerender-dev-server
branch
4 times, most recently
from
49c5abe
to
fdd5d6f
Compare
…pp-shell and SSG pages This commits, update the application builder and vite dev-server to be able to serve the app-shell and prerendered pages.
alan-agius4
force-pushed
the
ssr-prerender-dev-server
branch
from
fdd5d6f
to
96cd507
Compare
alan-agius4
added
action: review
clydin
approved these changes
Aug 11, 2023
| @@ -164,7 +164,7 @@ export function createServerCodeBundleOptions( | |||
| const polyfills = [`import '@angular/platform-server/init';`]; | |||
|
|
|||
| if (options.polyfills?.includes('zone.js')) { | |||
| polyfills.push(`import 'zone.js/node';`); | |||
| polyfills.push(`import 'zone.js/fesm2015/zone-node.js';`); | |||
There was a problem hiding this comment.
I think we should consider updating the zone.js package to include a exports definition so we don't have to deep import.
There was a problem hiding this comment.
Yeah, we should that.
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits, update the application builder and vite dev-server to be able to serve the app-shell and prerendered pages.