Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): ensure localize polyfill and locale specifier are injected when not inlining #25982

Merged
merged 1 commit into from Oct 9, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 8, 2023

When using the esbuild-based builders (application/browser-esbuild), the localize polyfill and the locale specifier for the configured source locale will now be injected into the application when available and the application is not configured to inline translations (localize option disabled or otherwise not used). This is useful for when developing a localized application with the development server or when the application is not translated but has a customized source locale.

@clydin clydin added the target: major This PR is targeted for the next major release label Oct 8, 2023
@clydin clydin linked an issue Oct 8, 2023 that may be closed by this pull request
1 task
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Oct 9, 2023
@clydin clydin marked this pull request as ready for review October 9, 2023 15:05
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Oct 9, 2023
…le specifier are injected when not inlining

When using the esbuild-based builders (`application`/`browser-esbuild`), the localize polyfill and the locale specifier
for the configured source locale will now be injected into the application when available and the application is not
configured to inline translations (`localize` option disabled or otherwise not used). This is useful for when developing
a localized application with the development server or when the application is not translated but has a customized source
locale.
@alan-agius4 alan-agius4 merged commit 3ad028b into angular:main Oct 9, 2023
33 checks passed
@clydin clydin deleted the esbuild/i18n-locale-init branch October 9, 2023 17:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browser-esbuild builder ignores sourceLocale in dev server application builder issue with localize
2 participants