Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(@angular-devkit/build-angular): only rebundle browser polyfills on explicit changes #26165

Merged
merged 1 commit into from Oct 30, 2023
Merged

perf(@angular-devkit/build-angular): only rebundle browser polyfills on explicit changes #26165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@ import type { NormalizedApplicationBuildOptions } from '../../builders/applicati
import { allowMangle } from '../../utils/environment-options';
import { createCompilerPlugin } from './angular/compiler-plugin';
import { SourceFileCache } from './angular/source-file-cache';
import { BundlerOptionsFactory } from './bundler-context';
import { createCompilerPluginOptions } from './compiler-plugin-options';
import { createAngularLocaleDataPlugin } from './i18n-locale-plugin';
import { createRxjsEsmResolutionPlugin } from './rxjs-esm-resolution-plugin';
Expand Down Expand Up @@ -73,7 +74,7 @@ export function createBrowserPolyfillBundleOptions(
options: NormalizedApplicationBuildOptions,
target: string[],
sourceFileCache?: SourceFileCache,
): BuildOptions | undefined {
): BuildOptions | BundlerOptionsFactory | undefined {
const namespace = 'angular:polyfills';
const polyfillBundleOptions = getEsBuildCommonPolyfillsOptions(
options,
Expand All @@ -86,6 +87,7 @@ export function createBrowserPolyfillBundleOptions(
}

const { outputNames, polyfills } = options;
const hasTypeScriptEntries = polyfills?.some((entry) => /\.[cm]?tsx?$/.test(entry));

const buildOptions: BuildOptions = {
...polyfillBundleOptions,
Expand All @@ -103,7 +105,6 @@ export function createBrowserPolyfillBundleOptions(
};

// Only add the Angular TypeScript compiler if TypeScript files are provided in the polyfills
const hasTypeScriptEntries = polyfills?.some((entry) => /\.[cm]?tsx?$/.test(entry));
if (hasTypeScriptEntries) {
buildOptions.plugins ??= [];
const { pluginOptions, styleOptions } = createCompilerPluginOptions(
Expand All @@ -121,7 +122,10 @@ export function createBrowserPolyfillBundleOptions(
);
}

return buildOptions;
// Use an options factory to allow fully incremental bundling when no TypeScript files are present.
// The TypeScript compilation is not currently integrated into the bundler invalidation so
// cannot be used with fully incremental bundling yet.
return hasTypeScriptEntries ? buildOptions : () => buildOptions;
}

/**
Expand Down