Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): re-add -d alias for --dry-run #26685

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

alan-agius4
Copy link
Collaborator

This got accidentally deleted during the transition to yargs.

Closes #26496

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 15, 2023
This got accidentally deleted during the transition to yargs.

Closes angular#26496
@alan-agius4 alan-agius4 changed the title fix(@angular/cli): re-add -d aliases for --dry-run fix(@angular/cli): re-add -d alias for --dry-run Dec 15, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 15, 2023
@alan-agius4 alan-agius4 merged commit f7d5389 into angular:main Dec 15, 2023
32 checks passed
@alan-agius4 alan-agius4 deleted the dry-run-alias branch December 15, 2023 15:34
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 30, 2023
[A recent change in the CLI](angular/angular-cli#26685) added a `-d` flag to `ng generate` which is the same as the alias for `--directory` in the MDC migration. This caused an error, because the default boolean value from the CLI was being picked up and was failing the schema validation.

These changes remove the alias since it isn't really necessary.

Fixes angular#28335.
crisbeto added a commit to angular/components that referenced this pull request Dec 31, 2023
[A recent change in the CLI](angular/angular-cli#26685) added a `-d` flag to `ng generate` which is the same as the alias for `--directory` in the MDC migration. This caused an error, because the default boolean value from the CLI was being picked up and was failing the schema validation.

These changes remove the alias since it isn't really necessary.

Fixes #28335.
crisbeto added a commit to angular/components that referenced this pull request Dec 31, 2023
[A recent change in the CLI](angular/angular-cli#26685) added a `-d` flag to `ng generate` which is the same as the alias for `--directory` in the MDC migration. This caused an error, because the default boolean value from the CLI was being picked up and was failing the schema validation.

These changes remove the alias since it isn't really necessary.

Fixes #28335.

(cherry picked from commit b9450c9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a shortcut for --dry-run as -d
2 participants