perf(@angular/build): add persistent caching of JavaScript transformations #27635
+210
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
changed the title
clydin
force-pushed
the
esbuild/js-transform-file-cache
branch
4 times, most recently
from
78d4b1b
to
0c3cbe8
Compare
…tions When caching is enabled for the Angular CLI, the JavaScript transformer within the application build system will now perform persistent caching of its output. This allows for improved warm build times by removing the need to run the Angular linker and build optimizer steps against unchanged third-party code within each build. This does not affect hot rebuilds that would take place during watch mode since the outputs are already cached within memory. The on-disk storage of the cached data is handled by the `lmdb` package which provides fast key/value storage and built-in off-thread compression. This package is currently used by such projects as Gatsby and parcel for their respective caching subsystems. Warm production build of a new 18.0.0-rc.2 project with disabled caching: ``` Application bundle generation complete. [3.698 seconds] ``` With enabled caching: ``` Application bundle generation complete. [2.277 seconds] ```
clydin
force-pushed
the
esbuild/js-transform-file-cache
branch
from
0c3cbe8
to
1fa3ba0
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
May 14, 2024
alan-agius4
added
action: merge
sod
reviewed
May 14, 2024
| let cacheStore; | ||
| if (pluginOptions.sourceFileCache?.persistentCachePath) { | ||
| cacheStore = new LmbdCacheStore( | ||
| pluginOptions.sourceFileCache.persistentCachePath + '/angular-compiler.db', |
There was a problem hiding this comment.
I guess to make the windows users happy, this could be:
path.join(pluginOptions.sourceFileCache.persistentCachePath, 'angular-compiler.db')There was a problem hiding this comment.
Windows actually supports both path separators; but, yes it could.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When caching is enabled for the Angular CLI, the JavaScript transformer within the application build system will now perform persistent caching of its output. This allows for improved warm build times by removing the need to run the Angular linker and build optimizer steps against unchanged third-party code within each build. This does not affect hot rebuilds that would take place during watch mode since the outputs are already cached within memory. The on-disk storage of the cached data is handled by the
lmdbpackage which provides fast key/value storage and built-in off-thread compression. This package is currently used by such projects as Gatsby and parcel for their respective caching subsystems.Warm production build of a new 18.0.0-rc.2 project with disabled caching:
With enabled caching: