Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize Promise.all for Efficient Asynchronous Operations 🚀 #27862

Closed
wants to merge 1 commit into from

Conversation

sanjaiyan-dev
Copy link

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This pull request refactors the code to leverage Promise.all for running multiple asynchronous functions concurrently. By utilizing Promise.all, we achieve improved performance and readability when dealing with asynchronous operations.

Benefits of Promise.all:

  • Improved Performance: Promise.all allows all the asynchronous functions to execute concurrently, potentially leading to significant performance gains, especially when dealing with independent tasks.
  • Simplified Code: By using Promise.all, we can group multiple asynchronous operations into a single line, making the code more concise and easier to maintain.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the commit message according to the guidelines specified here: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#commit? In this instance, the commit type should be build.

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 17, 2024
@alan-agius4
Copy link
Collaborator

Thanks for the contribution but closing as PR feedback has not been addressed. Please feel free to open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants