Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): make ng update to keep newline at the end of package.json #27895

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

ddereszkiewicz
Copy link
Contributor

@ddereszkiewicz ddereszkiewicz commented Jun 21, 2024

As stated in #11744, ng update command removed the newline at the end of the package.json file. This commit makes ng update to preserve newline, if it was present before running the command.

Fixes #11744

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #11744

What is the new behavior?

ng update preserves the newline at the end of the package.json file

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 25, 2024
…kage.json

As stated in angular#11744,
`ng update` command removed the newline at the end of the package.json file.
This commit makes `ng update` to preserve newline, if it was present before running the command.

Fixes angular#11744
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 26, 2024
@dgp1130 dgp1130 merged commit 4947f29 into angular:main Jun 27, 2024
32 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Jun 27, 2024

The changes were merged into the following branches: main, 18.0.x, 18.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng update/add remove newline in package.json
3 participants