chore(): allow the CLI tool itself to use TypeScript. #291
Conversation
hansl
force-pushed
the
typescript
branch
2 times, most recently
from
6dba102
to
3764eba
Compare
hansl
force-pushed
the
typescript
branch
8 times, most recently
from
a11bc07
to
c687237
Compare
|
|
||
| return Promise.reject(new SilentError(message)); | ||
| return Promise.reject(new SilentError( | ||
| `The "ng ${this.name}" command requires a name argument to be specified. ` + |
There was a problem hiding this comment.
You dropped the use of chalk.yellow here, was it intended?
There was a problem hiding this comment.
It's an error, it's weird to use a yellow() text.
|
Oh man this is nice! What's stopping you from just bringing in the brocolli |
|
The broccoli should only be |
hansl
force-pushed
the
typescript
branch
2 times, most recently
from
30de1c4
to
c6de2aa
Compare
This does not work for the Broccoli (yet).
| @@ -1,19 +1,15 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
I believe you should add the typings at the first line;
/// <reference path="../../../typings/main.d.ts" />
also, run typings install in package.json in postinstall script.
If not, just ignore this.
|
Good work. LGTM. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This does not work for the Broccoli (yet).