feat(generate): add guard generation #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delasteve
force-pushed
the
feature/guard-generation
branch
2 times, most recently
from
c7edf88
to
a01a84c
Compare
delasteve
changed the title
delasteve
force-pushed
the
feature/guard-generation
branch
2 times, most recently
from
d22a073
to
ca510f3
Compare
delasteve
force-pushed
the
feature/guard-generation
branch
from
22e5caf
to
b7648d6
Compare
hansl
suggested changes
Jan 31, 2017
| @@ -234,6 +234,10 @@ | |||
| "type": "boolean", | |||
| "default": true | |||
| }, | |||
| "guard": { | |||
| "type": "boolean", | |||
delasteve
force-pushed
the
feature/guard-generation
branch
from
b7648d6
to
fe19e9d
Compare
|
@hansl, could I get a re-review? Thanks! |
delasteve
force-pushed
the
feature/guard-generation
branch
from
fe19e9d
to
332be0c
Compare
|
@hansl could I get a rebuild on |
delasteve
force-pushed
the
feature/guard-generation
branch
3 times, most recently
from
b0bc3aa
to
d9f8fbf
Compare
filipesilva
approved these changes
Feb 14, 2017
hansl
approved these changes
Feb 17, 2017
delasteve
force-pushed
the
feature/guard-generation
branch
2 times, most recently
from
73a9273
to
c554daf
Compare
|
@delasteve there seems to be some broken tests with your latest changes. |
delasteve
force-pushed
the
feature/guard-generation
branch
3 times, most recently
from
57cbe7e
to
503931b
Compare
delasteve
force-pushed
the
feature/guard-generation
branch
from
503931b
to
3175d86
Compare
bcabanes
added a commit
to bcabanes/angular-cli
that referenced
this pull request
Feb 27, 2017
Add the Guard param on the options table of the generator in the README. It was implemented by angular#4055.
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
Add the Guard param on the options table of the generator in the README. It was implemented by angular#4055. Close angular#5069
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.