Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: When generating a NgModule, allow -m to indicate which NgModule should import it #5377

Closed
johnpapa opened this issue Mar 11, 2017 · 1 comment · Fixed by #5485
Closed

Comments

@johnpapa
Copy link
Contributor

OS

Mac OSX Sierra 10.12.3

Versions

@angular/cli: 1.0.0-rc.1
node: 6.9.1
os: darwin x64
@angular/common: 2.4.9
@angular/compiler: 2.4.9
@angular/core: 2.4.9
@angular/forms: 2.4.9
@angular/http: 2.4.9
@angular/platform-browser: 2.4.9
@angular/platform-browser-dynamic: 2.4.9
@angular/router: 3.4.9
@angular/cli: 1.0.0-rc.1
@angular/compiler-cli: 2.4.9

Repro steps.

ng g m login -m app.module doesn't look for the -m option today . But i think it would be helpful to be able to create a NgModule and tell the CLI where you want it imported (in another module).

Without this, today we must manually import it.

This would allow it to work similar to how ng g s data -m some.module and ng g c customer -mother.module work today

delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 17, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 17, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 18, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 18, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue Apr 1, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue Apr 1, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue Apr 5, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue May 2, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue May 2, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue May 4, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue May 4, 2017
filipesilva pushed a commit that referenced this issue May 8, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants