Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular/cli): add import flag to modules #5485

Merged
merged 1 commit into from
May 8, 2017

Conversation

delasteve
Copy link
Contributor

closes #5377

Currently depends on PR #5467 - this will be rebased once in master

@delasteve delasteve force-pushed the feat/module-import-module branch 3 times, most recently from 388d708 to ed55473 Compare March 18, 2017 11:19
@delasteve delasteve force-pushed the feat/module-import-module branch 2 times, most recently from 64782c8 to 12954d8 Compare April 1, 2017 18:03
@delasteve delasteve changed the base branch from master to 1.1.x April 1, 2017 18:03
@delasteve delasteve changed the title feat(@angular/cli): add import flag to modules [WIP] feat(@angular/cli): add import flag to modules Apr 1, 2017
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 5, 2017
@hansl hansl changed the title [WIP] feat(@angular/cli): add import flag to modules feat(@angular/cli): add import flag to modules Apr 5, 2017
@hansl
Copy link
Contributor

hansl commented Apr 5, 2017

CLA is good. It was due to multiple commits from difference authors. @delasteve has signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 2, 2017
@hansl hansl changed the base branch from 1.1.x to master May 4, 2017 00:36
@hansl
Copy link
Contributor

hansl commented May 4, 2017

Please rebase on top of master.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 4, 2017
@filipesilva filipesilva merged commit 8b220a4 into angular:master May 8, 2017
@delasteve delasteve deleted the feat/module-import-module branch August 16, 2018 13:04
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: When generating a NgModule, allow -m to indicate which NgModule should import it
4 participants