Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular/cli): Add postcss plugins #5850

Closed

Conversation

mikkeldamm
Copy link

Makes it possible to define postcss plugins that should be used with the postcss-loader. It is done be defining the plugins in the cli config as so:

"environments": { ... },
"postCssPlugins": [
    "postcss-cssnext",
    "postcss-nested",
    "postcss-mixins",
    ...
]

@mikkeldamm mikkeldamm force-pushed the allow-configured-postcss-plugins branch from 5143440 to 9ae000f Compare April 5, 2017 23:20
@mikkeldamm mikkeldamm force-pushed the allow-configured-postcss-plugins branch from 9ae000f to 9c5de9a Compare April 6, 2017 09:31
@dominikg
Copy link

dominikg commented Apr 6, 2017

given that bootstrap4 uses postcss-flexbugs-fixes[1] to generate its css this PR would enable angular-cli users to do the same and avoid issues[2] when integrating bootstrap4 source scss instead of dist css.

[1] twbs/bootstrap#19109
[2] twbs/bootstrap#20760

@sumitarora sumitarora requested review from filipesilva and hansl and removed request for filipesilva April 8, 2017 13:57
@mikkeldamm
Copy link
Author

@hansl @filipesilva can anyone of you look at this? 😺

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@filipesilva
Copy link
Contributor

I'm sorry, but this sort of costumization is not something we're looking at adding right now. It's not as simple as just adding the names, some plugins also need args and they need to be installed.

Can you instead open an issue where this can be discussed?

@filipesilva filipesilva closed this May 8, 2017
@cedvdb
Copy link

cedvdb commented Aug 25, 2017

@filipesilva similar to OP #7514

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants