fix(@angular/cli): ng completion inside of ng app folders warns but does not produce output
#7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an ng app folder was created with an older CLI version, then the ng CLI is upgraded globally, one cannot perform `ng completion` INSIDE that app folder. Thus it is advisable to only allow ng completion in places such as shell start-up code, for which the completion is meant in the first place. The completion call perfoemd in an ng app folder generated with an older version issues a warning, which the shell cannot ignored, but tries to interpret as genuine commands, and thus it fails miserably then and there. The change constitute a breaking change, because previously `ng completion` could be called from `everywhere`.
catull
changed the title
ng completion inside of ng app folders behave again
…der make it a shell comment.
catull
force-pushed
the
fix-6343-allow-ng-completion-only-outside-of-ng-app-folders
branch
from
1f1f20d
to
4434e5f
Compare
…it with return code 1.
catull
deleted the
fix-6343-allow-ng-completion-only-outside-of-ng-app-folders
branch
catull
changed the title
ng completion inside of ng app folders behave againng completion inside of ng app folders warns but does not produce output
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ng app folder was created with an older ng CLI version, and the ng CLI is upgraded globally, one cannot perform
ng completionINSIDE that app folder.Thus it is advisable to only allow
ng completionin placessuch as shell start-up code, for which the completion is meant in the first place.
ng completionperformed in an ng app folder generated with an older versionissues a warning, which the shell cannot ignore, but tries to interpret as genuine
shell commands, miserably failing. This warning must be prepended with shell comment characters.
The PR fixes #6343.
The change does not introduce a breaking change, it prevents the warning from being erroneously
interpreted by the shell.