Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): Generating component considers default style ext #7648

Merged
merged 2 commits into from Sep 20, 2017
Merged

fix(@angular/cli): Generating component considers default style ext #7648

merged 2 commits into from Sep 20, 2017

Conversation

AhsanAyaz
Copy link
Contributor

@AhsanAyaz AhsanAyaz commented Sep 10, 2017

@AhsanAyaz
Copy link
Contributor Author

AhsanAyaz commented Sep 13, 2017

@filipesilva , @Brocco , @hansl , can you please review this? I think I fixed #7522 too with this.
This would probably avoid anyone else to fix the same stuff.

@avatsaev
Copy link

Are there any unit tests for this?

Brocco
Brocco previously approved these changes Sep 19, 2017
@AhsanAyaz
Copy link
Contributor Author

AhsanAyaz commented Sep 19, 2017

@avatsaev Added unit test for the use case. Though I do need to discuss about use cases where we want to do the setupProject based on some extra parameters.
For instance right now all tests have this setup ng(['new', 'foo', '--skip-install'] in this file.
What if I need project set up with ng(['new', 'foo', '--skip-install', '--style', 'scss'] etc for a particular test or a suite.
Gonna create an issue probably for this.

@avatsaev
Copy link

avatsaev commented Sep 19, 2017

@AhsanAyaz that's great! Just be aware there is a commit message format, "Added unit-test" probably won't pass, must be something like "test (generate): add unit tests for styles extension"

@AhsanAyaz
Copy link
Contributor Author

@avatsaev Yeah watched the build failing. Really hurts. lol
Fixing it :)

@AhsanAyaz
Copy link
Contributor Author

AhsanAyaz commented Sep 19, 2017

@Brocco thanks for reviewing earlier.
I added the unit test. And the checks seem to be passing. You can re-review when you have some time. Thanks.

@Brocco Brocco merged commit a0a9250 into angular:master Sep 20, 2017
@musmanadil
Copy link

Awesome!

@grapgrap
Copy link

Awesome! Can i meet this at next version release?

@ninrod
Copy link

ninrod commented Nov 6, 2017

Hi, in what version was this landed?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate(component): Does not default to SCSS when specified in .angular-cli.json
7 participants