-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular/cli): show errors after warnings #8745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya @Taha-Di-Nero, these changes look good, but I think we can get this in as a fix instead.
Could you rename the commit to fix(@angular/cli): show errors after warnings
please?
Of course |
58e5e2a
to
acb9de8
Compare
@filipesilva why merging is blocked ?? |
Sorry it took awhile for me to come back to this PR. I've re-reviewed it and it should be ready. Thanks! |
It looks like this is moving the warnings before the output stats. I'm not sure this is a good idea as this can cause any warnings to be easily missed. Warnings and errors are both diagnostic messages and I think it would make more sense to group them together as such. Also, errors are already shown after warnings. So the current order is information, warnings, errors. This represents an increasing level of severity and therefore shows the most urgent message last; which could be considered the order of most utility. In regards to the actual underlying concern of too much text being displayed in a small console window, PR #8875 should provide partial relief. In addition, further work on reducing the verbosity of warnings and errors would also be a fruitful effort in this regard. |
To be honest I misunderstood the original issue (#8292). I thought warnings were actually showing after errors. I agree with @clydin here: the warnings are already being shown before the errors so I don't think there's any need to change. Apologies for that... I should have read read the issue and PR with more attention. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.