Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@ngtools/webpack): suppress warnings for overwriting files in tsc #8930

Merged
merged 1 commit into from Feb 1, 2018
Merged

fix(@ngtools/webpack): suppress warnings for overwriting files in tsc #8930

merged 1 commit into from Feb 1, 2018

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Dec 19, 2017 •
edited

Since we're using a virtual filesystem, overwriting files by tsc does
not affect actual files on the filesystem. This allows us to support
allowJs without changing any configuration quirks.

Fixes angular/angular#21080
Might help with #8371
Fixes #8885

@hansl hansl force-pushed the allow-js-fix branch 2 times, most recently from 0df9419 to feb7d5c Compare December 19, 2017 17:43
@filipesilva filipesilva mentioned this pull request Dec 26, 2017
Closed
filipesilva
filipesilva reviewed Dec 26, 2017
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is failing CI at the moment. @hansl can you fix it?

@vladimiry
Copy link

Any progress on the issue?

1 similar comment
@yianni-ververis
Copy link

Any progress on the issue?

@amyhartz amyhartz mentioned this pull request Jan 18, 2018
Merged
@vladimiry vladimiry mentioned this pull request Jan 21, 2018
Closed
@ameya
Copy link

ameya commented Jan 22, 2018

Any progress on this issue @hansl @filipesilva

@daveryderoxford
Copy link

@hansl @filipesilva Any update on this issue or ideas for a workaround. Im also waiting for it.

@majalcmaj
Copy link

@hansl @filipesilva Is there any progress on the issue?

@Luladjiev
Copy link

Same problem here. Our upgrade from AngularJS to Angular5 was blocked by this issue.

@Code4SocialGood Code4SocialGood mentioned this pull request Jan 24, 2018
Closed
@hansl hansl force-pushed the allow-js-fix branch 2 times, most recently from a5f350a to 51cc09f Compare January 31, 2018 21:50
@hansl
fix(@ngtools/webpack): suppress warnings for overwriting files in tsc
8771d86 
Since we're using a virtual filesystem, overwriting files by tsc does
not affect actual files on the filesystem. This allows us to support
allowJs without changing any configuration quirks.

Fixes angular/angular#21080
Might help with angular#8371
Fixes angular#8885
@hansl hansl changed the title fix(@ngtools/webpack): do not remove outDir from the configuration fix(@ngtools/webpack): suppress warnings for overwriting files in tsc Jan 31, 2018
@clydin clydin removed the state: WIP label Feb 1, 2018
@clydin clydin merged commit a61f5a6 into angular:master Feb 1, 2018
@gregjacobs
Copy link

Nicely done, thanks for this @hansl!

@NitishMutha
Copy link

NitishMutha commented Mar 5, 2018 •
edited

Could I please know in which release these changes will be applied and when will it be available? Thanks.
@hansl

@hansl hansl deleted the allow-js-fix branch November 28, 2018 23:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva left review comments

@clydin clydin clydin approved these changes

Assignees

@hansl hansl

Labels
None yet
Projects
None yet
Milestone
No milestone