feat(ngHintModules): install ngHintModules module

angular · Jul 30, 2014 · a59ff7f · a59ff7f
1 parent f957b46
commit a59ff7f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/hint.js b/hint.js
@@ -7,11 +7,12 @@ require('angular-hint-directives');
 require('angular-hint-dom');
 require('angular-hint-events');
 require('angular-hint-interpolation');
+require('angular-hint-modules');
 
 // List of all possible modules
 // The default ng-hint behavior loads all modules
 var allModules = ['ngHintControllers', 'ngHintDirectives', 'ngHintDom', 'ngHintEvents',
-  'ngHintInterpolation'];
+  'ngHintInterpolation', 'ngHintModules'];
 
 // Determine whether this run is by protractor.
 // If protractor is running, the bootstrap will already be deferred.
@@ -57,7 +58,8 @@ function loadModules() {
   } else if (document.querySelector('[ng-hint]')) {
     modules = allModules;
   } else {
-    angular.hint.logMessage('##General## ngHint is included on the page, but is not active because there is no `ng-hint` attribute present');
+    angular.hint.logMessage('##General## ngHint is included on the page, but is not active because'+
+      ' there is no `ng-hint` attribute present');
   }
   return modules;
 }

diff --git a/hint_test.js b/hint_test.js
@@ -11,7 +11,7 @@ describe('angularHint', function() {
           .toBe('Angular Hint: General Module ngHintWrongModuleName could not be found');
       browser.get('excludeWrongModuleName/');
       expect(element(by.id('console')).getText())
-          .toBe('Angular Hint: General Module ngHintExcludeWrongModuleName could not be found');
+          .toContain('Angular Hint: General Module ngHintExcludeWrongModuleName could not be found');
     });
 
 
@@ -30,7 +30,10 @@ describe('angularHint', function() {
         'in [object Object] scope');
       //angular-hint-interpolation
       expect(element(by.id('console')).getText()).toContain('was found to be undefined in');
-      // expect(element(by.id('console')).getText()).toContain('Module "sample" was created but never loaded');
+      //angular-hint-modules
+      expect(element(by.id('console')).getText()).toContain('Module "sampleAllHint" was created ' +
+        'but never loaded. Multiple modules with name "sampleAllHint" are being created and they' +
+        ' will overwrite each other.');
     });
 
 

diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
     "angular-hint-events": "^0.2.0",
     "angular-hint-interpolation": "^0.2.0",
     "angular-hint-log": "0.2.0",
-    "angular-hint-modules": "0.1.0"
+    "angular-hint-modules": "0.2.0"
   },
   "devDependencies": {
     "browserify": "^4.2.0",