Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

bindToController should support "scope" syntax/features #10420

Closed
johnlindquist opened this issue Dec 11, 2014 · 1 comment
Closed

bindToController should support "scope" syntax/features #10420

johnlindquist opened this issue Dec 11, 2014 · 1 comment
Labels
component: $compile type: feature
Milestone
1.4.x

Comments

@johnlindquist
Copy link
Contributor

currently, if you want to use "bindToController", you have to do this:

bindToController: true,
scope: {
message: "@"
}

to simplify, bindToController should support the scope syntax and automatically set to true:

bindToController: {
message: "@"
}

This helps explain what is actually happening and simplifies your code so it should be a simple win/win.
@lgalfaso lgalfaso added this to the 1.4.x milestone Dec 15, 2014
@lgalfaso
Copy link
Contributor

this looks reasonable, will mark it for 1.4.x and see what is the community feedback on this

caitp added a commit to caitp/angular.js that referenced this issue Dec 15, 2014
@caitp
feat($compile): allow using bindToController as object, support both …
9a97d4b 
…new/isolate scopes

bindToController is now able to be specified as a convenient object notation:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: {}
```

It can also be used in conjunction with new scopes, rather than exclusively isolate scopes:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: true
```

Closes angular#10420
@caitp caitp mentioned this issue Dec 15, 2014
Closed
caitp added a commit to caitp/angular.js that referenced this issue Dec 15, 2014
@caitp
feat($compile): allow using bindToController as object, support both …
7e77e03 
…new/isolate scopes

bindToController is now able to be specified as a convenient object notation:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: {}
```

It can also be used in conjunction with new scopes, rather than exclusively isolate scopes:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: true
```

Closes angular#10420
caitp added a commit to caitp/angular.js that referenced this issue Jan 19, 2015
@caitp
feat($compile): allow using bindToController as object, support both …
1838d75 
…new/isolate scopes

bindToController is now able to be specified as a convenient object notation:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: {}
```

It can also be used in conjunction with new scopes, rather than exclusively isolate scopes:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: true
```

Closes angular#10420
caitp added a commit to caitp/angular.js that referenced this issue Jan 27, 2015
@caitp
feat($compile): allow using bindToController as object, support both …
440cd41 
…new/isolate scopes

bindToController is now able to be specified as a convenient object notation:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: {}
```

It can also be used in conjunction with new scopes, rather than exclusively isolate scopes:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: true
```

Closes angular#10420
caitp added a commit to caitp/angular.js that referenced this issue Jan 29, 2015
@caitp
feat($compile): allow using bindToController as object, support both …
ee11ced 
…new/isolate scopes

bindToController is now able to be specified as a convenient object notation:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: {}
```

It can also be used in conjunction with new scopes, rather than exclusively isolate scopes:

```
bindToController: {
  text: '@text',
  obj: '=obj',
  expr: '&expr'
},
scope: true
```

Closes angular#10420
@caitp caitp closed this as completed in 35498d7 Jan 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: $compile type: feature
Projects
None yet
Milestone
1.4.x
2 participants
@johnlindquist @lgalfaso