This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat(limitTo): extend the filter to take a beginning index argument #10899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the limitTo filter to take an optional argument for beginning index. It provides a slice-alike functionality to manipulate the input. Closes #5355
|
Now that there is an |
|
But it is going to be a breaking change :( |
|
This PR seems good after a quick look - that is - it does what it announces. Having said this the resulting API is a bit odd... but I guess this is the best we can do without API breaking changes... Let's reach out to the community to see what other think... |
|
very cool thanks |
petebacondarwin
modified the milestones:
1.4.0-beta.3 / 1.3.12,
1.4.0-beta.4 / 1.3.13,
1.4.0-beta.5 / 1.3.14
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Extend the limitTo filter to take an optional argument for beginning index. It provides a slice-alike functionality to manipulate the input. Closes angular#5355 Closes angular#10899
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the limitTo filter to take an optional argument for beginning index. It provides a slice-alike functionality to manipulate the input.
Closes #5355