Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Testing with mocha #1589

Closed
cjroebuck opened this issue Nov 18, 2012 · 3 comments
Closed

Testing with mocha #1589

cjroebuck opened this issue Nov 18, 2012 · 3 comments

Comments

@cjroebuck
Copy link

Trying to get testing working with mocha, but doesn't seem like the changes in PR #1253 are in angular-mocks.js in the downloaded bundle from the main angular website. Tried both stable and unstable builds.

@pkozlowski-opensource
Copy link
Member

@cjroebuck changes from PR #1253 landed as 92558fe and are well in master. Simply there was no release since then.

Could you try the latest version from the integration server to see if this works for you?
http://ci.angularjs.org/view/AngularJS/job/angular.js-angular-master/ws/build/

@pkozlowski-opensource
Copy link
Member

@cjroebuck A new version of AngularJS was tagged yesterday: http://code.angularjs.org/1.1.1/
Mocha support is in this release.

@metamatt
Copy link
Contributor

Hopefully I'm not being a pain but I have an interest in seeing this working and I don't know the etiquette, if it's better to follow up on existing issue reports that describe the problem or to file new ones. The commit for Mocha support that landed in 1.1.1, 92558fe, doesn't actually work; see #1467. The 1.1.2 release and what's on ci.angularjs.org right now haven't changed anything in this respect.

metamatt added a commit to metamatt/angular.js that referenced this issue Feb 26, 2013
When running inside Mocha, don't look in Jasmine's spec.queue.running.
It's not there. This is documented as issue angular#1467; I think this issue was
also responsible for angular#1589 and recent complaints in angular#1253.

Closes angular#1467.
IgorMinar pushed a commit that referenced this issue Feb 26, 2013
When running inside Mocha, don't look in Jasmine's spec.queue.running.
It's not there. This is documented as issue #1467; I think this issue was
also responsible for #1589 and recent complaints in #1253.

Closes #1467.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants