Skip to content

Commit

Permalink
ci: temporarily disable chrome beta for saucelabs (#29518)
Browse files Browse the repository at this point in the history
We need to temporarily disable Chrome beta within the
`legacy-saucelabs-tests` and `test_saucelabs_bazel` job.

This is necessary because Saucelabs added Chrome v74 to their
beta version channel without providing the corresponding
chromedriver that is *required* for that beta version.

Explicitly specifying a chromedriver within the Selenium browser
capabilities doesn't seem to work because Saucelabs seems to mirror
their supported chromedriver versions. Meaning that we can't explicitly
use chromedriver.storage.googleapis.com/index.html?path=74.0.3729.6/

Re-enabling tracked with: FW-1205

PR Close #29518
  • Loading branch information
devversion authored and kara committed Mar 26, 2019
1 parent a5c9fa3 commit 0f1da49
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion browser-providers.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@
var CIconfiguration = {
'Chrome': {unitTest: {target: 'SL', required: true}, e2e: {target: null, required: true}},
'Firefox': {unitTest: {target: 'SL', required: true}, e2e: {target: null, required: true}},
'ChromeBeta': {unitTest: {target: 'SL', required: true}, e2e: {target: null, required: false}},
// Temporarily disabled because Saucelabs now runs Chrome v74 as beta version. Unfortunately
// Saucelabs doesn't provide a Chromedriver version that works for that beta version though.
// TODO(FW-1205): Re-enable once Saucelabs supports Chromedriver v74.0.3729.6.
'ChromeBeta': {unitTest: {target: 'SL', required: false}, e2e: {target: null, required: false}},
'ChromeDev': {unitTest: {target: 'SL', required: false}, e2e: {target: null, required: true}},
// FirefoxBeta and FirefoxDev should be target:'BS' or target:'SL', and required:true
// Currently deactivated due to https://github.com/angular/angular/issues/7560
Expand Down

0 comments on commit 0f1da49

Please sign in to comment.