Skip to content

Commit

Permalink
build: temporarily increase the commit msg limit to 120
Browse files Browse the repository at this point in the history
Right now HEAD and 5.0.x have a branch deviation and therefore
all the commits between both branches are being compared. There
exists a problematic commit which has a commit message that is
longer than 100 commits. This patch will temporarily increase
the limit to 120 so that CI passes. Once master is resumed to
being the primary development branch (once 5.0.0 is out) then
the the msg limit will be set back to 100.
  • Loading branch information
matsko committed Oct 31, 2017
1 parent 4864160 commit 45d6c02
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/validate-commit-message/commit-message.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"maxLength": 100,
"maxLength": 120,
"types": [
"build",
"ci",
Expand Down
4 changes: 2 additions & 2 deletions tools/validate-commit-message/validate-commit-message.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ describe('validate-commit-message.js', function() {

it('should validate 100 characters length', function() {
var msg =
'fix(compiler): something super mega extra giga tera long, maybe even longer and longer and longer... ';
'fix(compiler): something super mega extra giga tera long, maybe even longer and longer and longer and longer and longer and longer... ';

expect(validateMessage(msg)).toBe(INVALID);
expect(errors).toEqual([
'INVALID COMMIT MSG: "fix(compiler): something super mega extra giga tera long, maybe even longer and longer and longer... "\n => ERROR: The commit message is longer than 100 characters'
'INVALID COMMIT MSG: "fix(compiler): something super mega extra giga tera long, maybe even longer and longer and longer and longer and longer and longer... "\n => ERROR: The commit message is longer than 120 characters'
]);
});

Expand Down

0 comments on commit 45d6c02

Please sign in to comment.