Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(animations): make sure falsy values are added to _globalTimelineS…
…tyles (#46863) style values get added to the `_globalTimelineStyles` map in order to keep them so that they can be used across different timelines `_globalTimelineStyles` was previously a plain object but has been refactored to a map in #44482, as part of the update a check has been changed from a ternary operation to an or (||), causing falsy values (as 0) not to be added to the map anymore, apply the nullish coalescing operator (??) instead to make sure only `undefined` and `null` are filtered out also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves #46833 PR Close #46863
- Loading branch information
1 parent
6b8e60c
commit 536ded2
Showing
2 changed files
with
40 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters