-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:enter animation doesn't animate opacity #46833
Comments
…tyles style values get added to the _globalTimelineStyles map in order to keep them so that they can be used across different timelines _globalTimelineStyles was previsouly a plain object but has been refactored to a map in angular#44482, as part of the update a check has been changed from a ternary operation to an or, causing falsy values not to be added to the map anymore, re-apply a ternary operation check so that the original behavior is restored also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves angular#46833
…tyles style values get added to the `_globalTimelineStyles` map in order to keep them so that they can be used across different timelines `_globalTimelineStyles` was previsouly a plain object but has been refactored to a map in angular#44482, as part of the update a check has been changed from a ternary operation to an or, causing falsy values not to be added to the map anymore, re-apply a ternary operation check so that the original behavior is restored also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves angular#46833
…tyles style values get added to the `_globalTimelineStyles` map in order to keep them so that they can be used across different timelines `_globalTimelineStyles` was previously a plain object but has been refactored to a map in angular#44482, as part of the update a check has been changed from a ternary operation to an or, causing falsy values not to be added to the map anymore, re-apply a ternary operation check so that the original behavior is restored also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves angular#46833
@ilyakonrad good catch! the bug is indeed a regression caused by some accidental refactoring, a fix is on its way 🙂 🎉 Also thank you very much for all the information and the nice reproductions! they've been very helpful! 😄 |
@dario-piotrowicz Love the term "accidental refactoring", whatever that means 😆 |
yeah sorry for the silly term 😆 , anyways I was trying to say that some refactoring broke it by mistake, I'm sure you got the gist of it! 😆 |
…tyles style values get added to the `_globalTimelineStyles` map in order to keep them so that they can be used across different timelines `_globalTimelineStyles` was previously a plain object but has been refactored to a map in angular#44482, as part of the update a check has been changed from a ternary operation to an or (||), causing falsy values (as 0) not to be added to the map anymore, apply the nullish coalescing operator (??) instead to make sure only `undefined` and `null` are filtered out also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves angular#46833
…tyles style values get added to the `_globalTimelineStyles` map in order to keep them so that they can be used across different timelines `_globalTimelineStyles` was previously a plain object but has been refactored to a map in angular#44482, as part of the update a check has been changed from a ternary operation to an or (||), causing falsy values (as 0) not to be added to the map anymore, apply the nullish coalescing operator (??) instead to make sure only `undefined` and `null` are filtered out also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves angular#46833
…tyles (#46863) style values get added to the `_globalTimelineStyles` map in order to keep them so that they can be used across different timelines `_globalTimelineStyles` was previously a plain object but has been refactored to a map in #44482, as part of the update a check has been changed from a ternary operation to an or (||), causing falsy values (as 0) not to be added to the map anymore, apply the nullish coalescing operator (??) instead to make sure only `undefined` and `null` are filtered out also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves #46833 PR Close #46863
…tyles (#46863) style values get added to the `_globalTimelineStyles` map in order to keep them so that they can be used across different timelines `_globalTimelineStyles` was previously a plain object but has been refactored to a map in #44482, as part of the update a check has been changed from a ternary operation to an or (||), causing falsy values (as 0) not to be added to the map anymore, apply the nullish coalescing operator (??) instead to make sure only `undefined` and `null` are filtered out also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves #46833 PR Close #46863
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Which @angular/* package(s) are the source of the bug?
animations
Is this a regression?
Yes
Description
I have some components that should be rendered and destroyed with animation which changes transform, border radius and opacity properties, so I use
:enter
and:leave
animations. It worked perfectly prior to upgrading to v14.Now in v14
:leave
animation is working as it did in v13, while:enter
stopped animating opacity.Please provide a link to a minimal reproduction of the bug
https://stackblitz.com/edit/angular-ivy-5ktwcj
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
Here's how it worked in the version 13.3.11 https://stackblitz.com/edit/angular-ivy-dtsfmi.
Same code, same everything except the version of @angular/animations.
Also here's my
animations
setup:The text was updated successfully, but these errors were encountered: