Skip to content

Commit

Permalink
build: add github config for ng-dev configuration (#37097)
Browse files Browse the repository at this point in the history
Adds the gitub configuration to the ng-dev configuration. This github
configuration provides information needed for making API requests to
github.  Upcoming tooling related PRs will require these API requests
being possible.

PR Close #37097
  • Loading branch information
josephperrott authored and kara committed May 15, 2020
1 parent cb888af commit 6a6fbc3
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
7 changes: 7 additions & 0 deletions .ng-dev-config.ts
Expand Up @@ -72,8 +72,15 @@ const format = {
'buildifier': true
};

// Github metadata information for `ng-dev` commands.
const github = {
owner: 'angular',
name: 'angular',
};

// Export function to build ng-dev configuration object.
module.exports = {
commitMessage,
format,
github,
};
12 changes: 7 additions & 5 deletions dev-infra/utils/config.ts
Expand Up @@ -11,10 +11,10 @@ import {exec} from 'shelljs';

/** The common configuration for ng-dev. */
type CommonConfig = {
// Github repository configuration used for API Requests, determining upstream remote, etc.
/* Github repository configuration used for API Requests, determining upstream remote, etc. */
github: {
owner: string;
name: string;
owner: string,
name: string,
}
};

Expand All @@ -24,8 +24,10 @@ type CommonConfig = {
*/
export type NgDevConfig<T = {}> = CommonConfig&T;

// The filename expected for creating the ng-dev config, without the file
// extension to allow either a typescript or javascript file to be used.
/**
* The filename expected for creating the ng-dev config, without the file
* extension to allow either a typescript or javascript file to be used.
*/
const CONFIG_FILE_NAME = '.ng-dev-config';

/** The configuration for ng-dev. */
Expand Down

0 comments on commit 6a6fbc3

Please sign in to comment.