New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add github config for ng-dev configuration #37097
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
area: build & ci
Related the build and CI infrastructure of the project
state: blocked
target: patch
This PR is targeted for the next patch release
labels
May 13, 2020
josephperrott
force-pushed
the
ng-dev-base-config
branch
from
May 13, 2020 19:57
958ed02
to
6c30bea
Compare
devversion
reviewed
May 13, 2020
josephperrott
force-pushed
the
ng-dev-base-config
branch
from
May 13, 2020 23:04
60a8e60
to
7921230
Compare
josephperrott
added
action: merge
The PR is ready for merge by the caretaker
and removed
state: blocked
labels
May 13, 2020
@devversion Ready for another look |
kara
added
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
May 14, 2020
devversion
approved these changes
May 14, 2020
… typings Adds a gitub object to the common configuration for ng-dev. This github configuration provides information needed for making API requests to github.
Adds the gitub configuration to the ng-dev configuration. This github configuration provides information needed for making API requests to github. Upcoming tooling related PRs will require these API requests being possible.
josephperrott
force-pushed
the
ng-dev-base-config
branch
from
May 15, 2020 14:57
7921230
to
5ad5716
Compare
josephperrott
removed
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
May 15, 2020
kara
pushed a commit
that referenced
this pull request
May 15, 2020
Adds the gitub configuration to the ng-dev configuration. This github configuration provides information needed for making API requests to github. Upcoming tooling related PRs will require these API requests being possible. PR Close #37097
kara
pushed a commit
that referenced
this pull request
May 15, 2020
Adds the gitub configuration to the ng-dev configuration. This github configuration provides information needed for making API requests to github. Upcoming tooling related PRs will require these API requests being possible. PR Close #37097
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
… typings (angular#37097) Adds a gitub object to the common configuration for ng-dev. This github configuration provides information needed for making API requests to github. PR Close angular#37097
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
Adds the gitub configuration to the ng-dev configuration. This github configuration provides information needed for making API requests to github. Upcoming tooling related PRs will require these API requests being possible. PR Close angular#37097
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: build & ci
Related the build and CI infrastructure of the project
cla: yes
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the gitub configuration to the ng-dev configuration. This github
configuration provides information needed for making API requests to
github. Upcoming tooling related PRs will require these API requests
being possible.