Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add github config for ng-dev configuration #37097

Closed

Conversation

josephperrott
Copy link
Member

Adds the gitub configuration to the ng-dev configuration. This github
configuration provides information needed for making API requests to
github. Upcoming tooling related PRs will require these API requests
being possible.

@josephperrott josephperrott added area: build & ci Related the build and CI infrastructure of the project state: blocked target: patch This PR is targeted for the next patch release labels May 13, 2020
@ngbot ngbot bot added this to the needsTriage milestone May 13, 2020
dev-infra/utils/config.ts Outdated Show resolved Hide resolved
dev-infra/utils/config.ts Outdated Show resolved Hide resolved
dev-infra/utils/config.ts Outdated Show resolved Hide resolved
dev-infra/utils/config.ts Show resolved Hide resolved
@josephperrott josephperrott marked this pull request as ready for review May 13, 2020 23:05
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels May 13, 2020
@josephperrott
Copy link
Member Author

@devversion Ready for another look

@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 14, 2020
dev-infra/utils/config.ts Outdated Show resolved Hide resolved
… typings

Adds a gitub object to the common configuration for ng-dev. This github
configuration provides information needed for making API requests to
github.
Adds the gitub configuration to the ng-dev configuration. This github
configuration provides information needed for making API requests to
github.  Upcoming tooling related PRs will require these API requests
being possible.
@josephperrott josephperrott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 15, 2020
kara pushed a commit that referenced this pull request May 15, 2020
… typings (#37097)

Adds a gitub object to the common configuration for ng-dev. This github
configuration provides information needed for making API requests to
github.

PR Close #37097
kara pushed a commit that referenced this pull request May 15, 2020
Adds the gitub configuration to the ng-dev configuration. This github
configuration provides information needed for making API requests to
github.  Upcoming tooling related PRs will require these API requests
being possible.

PR Close #37097
@kara kara closed this in 20d377c May 15, 2020
kara pushed a commit that referenced this pull request May 15, 2020
Adds the gitub configuration to the ng-dev configuration. This github
configuration provides information needed for making API requests to
github.  Upcoming tooling related PRs will require these API requests
being possible.

PR Close #37097
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 15, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
… typings (angular#37097)

Adds a gitub object to the common configuration for ng-dev. This github
configuration provides information needed for making API requests to
github.

PR Close angular#37097
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
Adds the gitub configuration to the ng-dev configuration. This github
configuration provides information needed for making API requests to
github.  Upcoming tooling related PRs will require these API requests
being possible.

PR Close angular#37097
@josephperrott josephperrott deleted the ng-dev-base-config branch August 31, 2023 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants