Skip to content

Commit

Permalink
fixup! fix(ivy): record correct absolute source span for ngForOf expr…
Browse files Browse the repository at this point in the history
…essions
  • Loading branch information
ayazhafiz committed Jul 29, 2019
1 parent c7be674 commit 796271d
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions packages/compiler/src/template_parser/binding_parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ export class BindingParser {
boundProps);
} else {
this._reportError(
`Value of the host property binding "${
propName}" needs to be a string representing an expression but got "${
expression}" (${typeof expression})`,
`Value of the host property binding "${propName}" needs to be a string representing an expression but got "${expression}" (${typeof expression})`,
sourceSpan);
}
});
Expand Down Expand Up @@ -91,9 +89,7 @@ export class BindingParser {
this.parseEvent(propName, expression, sourceSpan, sourceSpan, [], targetEvents);
} else {
this._reportError(
`Value of the host listener "${
propName}" needs to be a string representing an expression but got "${
expression}" (${typeof expression})`,
`Value of the host listener "${propName}" needs to be a string representing an expression but got "${expression}" (${typeof expression})`,
sourceSpan);
}
});
Expand Down Expand Up @@ -361,15 +357,13 @@ export class BindingParser {

default:
this._reportError(
`The provided animation output phase value "${phase}" for "@${
eventName}" is not supported (use start or done)`,
`The provided animation output phase value "${phase}" for "@${eventName}" is not supported (use start or done)`,
sourceSpan);
break;
}
} else {
this._reportError(
`The animation trigger output event (@${
eventName}) is missing its phase value name (start or done are currently supported)`,
`The animation trigger output event (@${eventName}) is missing its phase value name (start or done are currently supported)`,
sourceSpan);
}
}
Expand Down

0 comments on commit 796271d

Please sign in to comment.