-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(aio): migrate embedded comp to elements (#22413)
PR Close #22413
- Loading branch information
1 parent
22b96b9
commit 7c9b411
Showing
69 changed files
with
1,021 additions
and
1,753 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +0,0 @@ | ||
| import { TestBed } from '@angular/core/testing'; | ||
| import { AppModule } from 'app/app.module'; | ||
| import { ComponentsOrModulePath, EMBEDDED_COMPONENTS } from 'app/embed-components/embed-components.service'; | ||
| import { embeddedComponents } from 'app/embedded/embedded.module'; | ||
|
|
||
| describe('AppModule', () => { | ||
| let componentsMap: {[multiSelectorstring: string]: ComponentsOrModulePath}; | ||
|
|
||
| beforeEach(() => { | ||
| TestBed.configureTestingModule({imports: [AppModule]}); | ||
| componentsMap = TestBed.get(EMBEDDED_COMPONENTS); | ||
| }); | ||
|
|
||
| it('should provide a map of selectors to embedded components (or module)', () => { | ||
| const allSelectors = Object.keys(componentsMap); | ||
|
|
||
| expect(allSelectors.length).toBeGreaterThan(1); | ||
| allSelectors.forEach(selector => { | ||
| const value = componentsMap[selector]; | ||
| const isArrayOrString = Array.isArray(value) || (typeof value === 'string'); | ||
| expect(isArrayOrString).toBe(true); | ||
| }); | ||
| }); | ||
|
|
||
| it('should provide a list of eagerly-loaded embedded components', () => { | ||
|
|
||
| const eagerConfig = Object.keys(componentsMap).filter(selector => Array.isArray(componentsMap[selector])); | ||
| expect(eagerConfig.length).toBeGreaterThan(0); | ||
|
|
||
| const eagerSelectors = eagerConfig.reduce<string[]>((selectors, config) => selectors.concat(config.split(',')), []); | ||
| expect(eagerSelectors.length).toBeGreaterThan(0); | ||
|
|
||
| // For example... | ||
| expect(eagerSelectors).toContain('aio-toc'); | ||
| expect(eagerSelectors).toContain('aio-announcement-bar'); | ||
| }); | ||
|
|
||
| it('should provide a list of lazy-loaded embedded components', () => { | ||
| const lazySelector = Object.keys(componentsMap).find(selector => selector.includes('code-example'))!; | ||
| const selectorCount = lazySelector.split(',').length; | ||
|
|
||
| expect(lazySelector).not.toBeNull(); | ||
| expect(selectorCount).toBe(embeddedComponents.length); | ||
|
|
||
| // For example... | ||
| expect(lazySelector).toContain('code-example'); | ||
| expect(lazySelector).toContain('code-tabs'); | ||
| expect(lazySelector).toContain('live-example'); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
aio/src/app/custom-elements/announcement-bar/announcement-bar.module.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import { NgModule, Type } from '@angular/core'; | ||
| import { CommonModule } from '@angular/common'; | ||
| import { HttpClientModule } from '@angular/common/http'; | ||
| import { SharedModule } from '../../shared/shared.module'; | ||
| import { AnnouncementBarComponent } from './announcement-bar.component'; | ||
| import { WithCustomElementComponent } from '../element-registry'; | ||
|
|
||
| @NgModule({ | ||
| imports: [ CommonModule, SharedModule, HttpClientModule ], | ||
| declarations: [ AnnouncementBarComponent ], | ||
| entryComponents: [ AnnouncementBarComponent ], | ||
| }) | ||
| export class AnnouncementBarModule implements WithCustomElementComponent { | ||
| customElementComponent: Type<any> = AnnouncementBarComponent; | ||
| } |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { NgModule, Type } from '@angular/core'; | ||
| import { CommonModule } from '@angular/common'; | ||
| import { HttpClientModule } from '@angular/common/http'; | ||
| import { SharedModule } from '../../shared/shared.module'; | ||
| import { ApiListComponent } from './api-list.component'; | ||
| import { ApiService } from './api.service'; | ||
| import { WithCustomElementComponent } from '../element-registry'; | ||
|
|
||
| @NgModule({ | ||
| imports: [ CommonModule, SharedModule, HttpClientModule ], | ||
| declarations: [ ApiListComponent ], | ||
| entryComponents: [ ApiListComponent ], | ||
| providers: [ ApiService ] | ||
| }) | ||
| export class ApiListModule implements WithCustomElementComponent { | ||
| customElementComponent: Type<any> = ApiListComponent; | ||
| } |
File renamed without changes.
File renamed without changes.
Oops, something went wrong.