Skip to content

Commit

Permalink
build: add release as a valid commit message subject (#19955)
Browse files Browse the repository at this point in the history
PR Close #19955
  • Loading branch information
matsko committed Oct 31, 2017
1 parent bf57df3 commit 951bd33
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions tools/validate-commit-message/commit-message.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"fix",
"perf",
"refactor",
"release",
"style",
"test"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ describe('validate-commit-message.js', function() {
expect(validateMessage('refactor(platform-webworker): something')).toBe(VALID);
expect(validateMessage('test(language-service): something')).toBe(VALID);
expect(validateMessage('test(packaging): something')).toBe(VALID);
expect(validateMessage('release: something')).toBe(VALID);
expect(validateMessage('release(packaging): something')).toBe(VALID);
expect(errors).toEqual([]);
});

Expand Down Expand Up @@ -65,6 +67,7 @@ describe('validate-commit-message.js', function() {
.forEach((expectedErrorMessage, index) => {
expect(expectedErrorMessage).toEqual(errors[index]);
});
expect(validateMessage('release(angular): something')).toBe(INVALID);
});


Expand Down Expand Up @@ -106,7 +109,7 @@ describe('validate-commit-message.js', function() {
expect(errors).toEqual(
['INVALID COMMIT MSG: "weird($filter): something"\n' +
' => ERROR: weird is not an allowed type.\n' +
' => TYPES: build, ci, docs, feat, fix, perf, refactor, style, test']);
' => TYPES: build, ci, docs, feat, fix, perf, refactor, release, style, test']);
});


Expand Down

0 comments on commit 951bd33

Please sign in to comment.