Skip to content

Commit

Permalink
fix: prevent strictNullChecks support until #15432 is fixed (#15434)
Browse files Browse the repository at this point in the history
  • Loading branch information
IgorMinar authored and vicb committed Mar 23, 2017
1 parent 0dda01e commit b800a0c
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 4 deletions.
3 changes: 2 additions & 1 deletion integration/hello_world__closure/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"compilerOptions": {
"module": "es2015",
"moduleResolution": "node",
"strictNullChecks": true,
// TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432
"strictNullChecks": false,
"target": "es6",
"noImplicitAny": false,
"sourceMap": false,
Expand Down
3 changes: 2 additions & 1 deletion integration/typings_test_ts21/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"target": "es5",
"lib": ["es5", "dom", "es2015.collection", "es2015.iterable", "es2015.promise"],
"types": [],
"strictNullChecks": true
// TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432
"strictNullChecks": false
},
"files": [
"include-all.ts",
Expand Down
3 changes: 2 additions & 1 deletion integration/typings_test_ts22/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"es2015.promise"
],
"types": [],
"strictNullChecks": true
// TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432
"strictNullChecks": false
},
"files": [
"include-all.ts",
Expand Down
6 changes: 6 additions & 0 deletions packages/core/public_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,9 @@
export * from './src/core';

// This file only reexports content of the `src` folder. Keep it that way.

// This is a hack to prevent people from turning on strictNullChecks. See #15432
export declare interface ɵStrictNullChecksNotSupported {
dontUseStrictNullChecksWithAngularYetSeeIssue15432: string|null;
[key: string]: string;
}
3 changes: 2 additions & 1 deletion packages/platform-server/integrationtest/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"compilerOptions": {
"module": "es2015",
"moduleResolution": "node",
"strictNullChecks": true,
// TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432
"strictNullChecks": false,
"target": "es6",
"noImplicitAny": false,
"sourceMap": false,
Expand Down

0 comments on commit b800a0c

Please sign in to comment.