Skip to content

Commit

Permalink
refactor(animations): remove deprecated matchesElement from `Animat…
Browse files Browse the repository at this point in the history
…ionDriver` (#55479)

BREAKING CHANGE: Deprecated `matchesElement` method has been removed from `AnimationDriver` as it is unused.

PR Close #55479
  • Loading branch information
alan-agius4 authored and alxhub committed Apr 23, 2024
1 parent eecde2e commit bcce85a
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 28 deletions.
4 changes: 0 additions & 4 deletions goldens/public-api/animations/browser/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ export abstract class AnimationDriver {
abstract containsElement(elm1: any, elm2: any): boolean;
abstract getParentElement(element: unknown): unknown;
// @deprecated (undocumented)
abstract matchesElement(element: any, selector: string): boolean;
// @deprecated (undocumented)
static NOOP: AnimationDriver;
// (undocumented)
abstract query(element: any, selector: string, multi: boolean): any[];
Expand All @@ -38,8 +36,6 @@ export class NoopAnimationDriver implements AnimationDriver {
containsElement(elm1: any, elm2: any): boolean;
// (undocumented)
getParentElement(element: unknown): unknown;
// @deprecated (undocumented)
matchesElement(_element: any, _selector: string): boolean;
// (undocumented)
query(element: any, selector: string, multi: boolean): any[];
// (undocumented)
Expand Down
2 changes: 0 additions & 2 deletions goldens/public-api/animations/browser/testing/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ export class MockAnimationDriver implements AnimationDriver {
// (undocumented)
static log: AnimationPlayer[];
// (undocumented)
matchesElement(_element: any, _selector: string): boolean;
// (undocumented)
query(element: any, selector: string, multi: boolean): any[];
// (undocumented)
validateAnimatableStyleProperty(prop: string): boolean;
Expand Down
13 changes: 0 additions & 13 deletions packages/animations/browser/src/render/animation_driver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,6 @@ export class NoopAnimationDriver implements AnimationDriver {
return validateStyleProperty(prop);
}

/**
* @deprecated unused
*/
matchesElement(_element: any, _selector: string): boolean {
// This method is deprecated and no longer in use so we return false.
return false;
}

/**
*
* @returns Whether elm1 contains elm2.
Expand Down Expand Up @@ -91,11 +83,6 @@ export abstract class AnimationDriver {

abstract validateAnimatableStyleProperty?: (prop: string) => boolean;

/**
* @deprecated No longer in use. Will be removed.
*/
abstract matchesElement(element: any, selector: string): boolean;

abstract containsElement(elm1: any, elm2: any): boolean;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@ export class WebAnimationsDriver implements AnimationDriver {
return true;
}

matchesElement(_element: any, _selector: string): boolean {
// This method is deprecated and no longer in use so we return false.
return false;
}

containsElement(elm1: any, elm2: any): boolean {
return containsElement(elm1, elm2);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ export class MockAnimationDriver implements AnimationDriver {
return ɵvalidateWebAnimatableStyleProperty(cssProp);
}

matchesElement(_element: any, _selector: string): boolean {
return false;
}

containsElement(elm1: any, elm2: any): boolean {
return containsElement(elm1, elm2);
}
Expand Down

0 comments on commit bcce85a

Please sign in to comment.