Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: tighten size threshold to 1% or 500 bytes (#33969)
The size diff threshold of 1% has proven to be too lenient for us to catch size regressions in AIO. Since the AIO main bundle is between 400-500 KB, a size regression must be between 4-5 KB before it will cause the tests to fail. As a result, we may merge many changes with smaller regressions of a few KB before the size test eventually lets us know that the number has increased. The hope is that lowering the threshold will help us catch the smaller regressions during code review and prevent the size tests failing at a random later time when someone catches the size "hot potato". PR Close #33969
- Loading branch information
Showing
3 changed files
with
29 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters