Skip to content

Commit

Permalink
build: remove the deprecated aio commit message scope (#32341)
Browse files Browse the repository at this point in the history
The `aio` commit message scope was renamed to `docs-infra` (which is
more descriptive) in #24295. Although it has been removed from the
documentation, the legacy `aio` scope was kept in the [list of valid
scopes][1] to cater for in-flight PRs that already used it. As a result,
it still shows up as a recommended, valid scope in the error message
shown when commit message validation fails during `git commit`. This is
misleading, especially for new contributors.

Since we have been "manually" discouraging people from using `aio`,
there should be no open PRs by now (and if there are, they should be
changed to `docs-infra`), so it is safe to remove it from the list of
allowed scopes.

Related discussion:
#32273 (review)

[1]: https://github.com/angular/angular/blob/3df54be9e/tools/validate-commit-message/commit-message.json#L16

PR Close #32341
  • Loading branch information
gkalpak authored and atscott committed Aug 27, 2019
1 parent 0874bf4 commit f57c17d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tools/validate-commit-message/commit-message.json
Expand Up @@ -13,7 +13,6 @@
"test"
],
"scopes": [
"aio",
"animations",
"bazel",
"benchpress",
Expand Down

0 comments on commit f57c17d

Please sign in to comment.