angular2 library: need finals

[kevmoo]

• All tokens
• defaultPipes - src/change_detection/change_detection.dart

If this relates to a tweaks to another tool, great. I'd love to keep this open until it's resolved, though.

[mprobst]

Sorry, I don't understand the issue description (NO_CHANGE? All tokens?). Can you expand? Does this relate to the const vs final issue we discussed?

[mprobst]

@kevmoo ping?

[kevmoo]

@mprobst Digging in now. Will provide details shortly.

[kevmoo]

src/change_detection/change_detection.dart. defaultPipes is a mutable hash.

var defaultPipes = {
  "iterableDiff": iterableDiff,
  "keyValDiff": keyValDiff,
  "async": async,
  "uppercase": uppercase,
  "lowercase": lowercase,
  "json": json
};

Ideally, it'd be

const Map defaultPipes = const <String, dynamic>{
  "iterableDiff": iterableDiff,
  "keyValDiff": keyValDiff,
  "async": async,
  "uppercase": uppercase,
  "lowercase": lowercase,
  "json": json
};

[mprobst]

@kevmoo we do support const hashes:

const defaultPipes = CONST_EXPR({
  "iterableDiff": iterableDiff,
  "keyValDiff": keyValDiff,
  "async": async,
  "uppercase": uppercase,
  "lowercase": lowercase,
  "json": json
});

[mprobst]

I see, you're already fixing it :-)

[kevmoo]

@mprobst I'm blocked, though. Can you help with dart-archive/ts2dart#217 ?

[yjbanov]

Does this issue need more work? Should it be closed? If not, would it be reasonable to expect that it will be closed in alpha-29?

[mprobst]

I think this should be fixed. @kevmoo ?

[kevmoo]

I've got a CL landed that takes care of this for top-level members in the angular2 lib.

I think there are a lot more places where things should be final, but top-level members – since they are shared – are clearly the most important.

We may just need to do an occasional review of the API to find bad examples.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}