4.0.0-rc.2 - es5 - CanDeactivate with EventEmitter

[uparlange]

I'm submitting a ... (check one with "x")

[ * ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see

Current behavior
CanDeactivate does not work with EventEmitter !

Expected behavior
CanDeactivate should work with true/false and with EventEmitter

Minimal reproduction of the problem with instructions
https://embed.plnkr.co/tPtY1a31CnFqhNbzVViU/
--> Unable to return to Home when List Displayed

What is the motivation / use case for changing the behavior?
CanDeactivate should work with true/false and with EventEmitter

Please tell us about your environment:
Windows 7 / VisualCode / NPM / Express

• Angular version: 2.0.X
  4.0.0-rc.2

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  All

• Language: [all | TypeScript X.X | ES6/7 | ES5]
  ES5

• Node (for AoT issues): node --version =
  Not concerned

[DzmitryShylovich]

did you try .take(1)?

[uparlange]

Can you be more specific ?

[DzmitryShylovich]

You need to complete the stream.

[uparlange]

Ok... Did you try with my plnkr sample... It does not seem to change anything... except having errors !

[DzmitryShylovich]

I'm not familiar with angular es5 but ts version works fine http://plnkr.co/edit/FGGSd80pDDp5HTCGGC8y?p=preview so it's something wrong with your config and not an angular issue

Plus your example doesn't even work with the most trivial Observable.of(true)

[uparlange]

Your sample is not the same as mine as i'm lazy loading the components.
My CanDeactivate Guard is defined on child module and not in main module.

[DzmitryShylovich]

Ok still works :)
https://plnkr.co/edit/1i9MtpkggOd5AZL0Nwfa?p=preview

[uparlange]

Humm ok.
What i don't understand is that it was working with 4.0.0-rc.1 and workaround described in #14603.
It is not working anymore with 4.0.0-rc.2.
I've updated the plunker to show you : https://embed.plnkr.co/tPtY1a31CnFqhNbzVViU/

[tbosch]

@uparlange did this work in 2.x?

[tbosch]

@uparlange Your latest punker seems to work, i.e. I can navigate from Home to List and back...

[DzmitryShylovich]

@tbosch the latest plunkr uses rc1.

What i don't understand is that it was working with 4.0.0-rc.1. It is not working anymore with 4.0.0-rc.2.

[DzmitryShylovich]

it does work with ts version so it's something wrong with es5 distribution. I'm not very familiar with it

[tbosch]

Ok, I can reproduce now if I change the latest plunker manually to use v2 (i.e. change index.html to load v2...)

[vicb]

Nothing has changed in the router in-between rc1 and rc2

Night be related to #14603 / #14820 (the latter was part of rc2), @jasonaden could you please chime in ?

Note: seems to work with rc1 and no more in rc2 and rc3.

[jasonaden]

There was a change after rc.1 (move from babel back to rollup to generate UMDs) which made the workaround (adding to global Rx) stop working. We are looking at how to get a fix in for ReactiveX/rxjs#2415 or a usable workaround that should fix this issue for the next RC.

[uparlange]

Meanwhile and as a workaround we can change the eventemitter way by a Promise.

canDeactivate:function(component)
{
return new Promise((resolve) =>
{
resolve(true);
});
}

[DzmitryShylovich]

@jasonaden don't look like anybody cares in rxjs repo :)

As a workaround I suggest to change impl and just check if object has subscribe property (like it was in rc1). It's nice to use observable symbol, but if it causes issues I think we can live without it. I can send a PR

[jasonaden]

@DzmitryShylovich Sounds good on the PR.

[DzmitryShylovich]

@jasonaden done #15171

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}