Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get a comment in the template #15143

Closed
teabagp opened this issue Mar 14, 2017 · 4 comments
Closed

get a comment in the template #15143

teabagp opened this issue Mar 14, 2017 · 4 comments
Labels
area: core Issues related to the framework runtime regression Indicates than the issue relates to something that worked in a previous version type: bug/fix

Comments

@teabagp
Copy link

teabagp commented Mar 14, 2017

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior
When i use empty template, i get a comment in component (this ).
This behavior occurred after the update to 4.0.0-rc.1

Expected behavior
In 4.0.0-beta.8 I get empty component

Minimal reproduction of the problem with instructions
angular 4.0.0-rc.1
http://plnkr.co/edit/C4uCLuL5pQqsH8ToR5yS?p=preview

angular 4.0.0-beta.8
http://plnkr.co/edit/8TnxGwzojU2Z026RcaHD?p=preview

  • Angular version: 4.0.0-rc.1
  • Browser: all
@DzmitryShylovich
Copy link
Contributor

DzmitryShylovich commented Mar 14, 2017

This change was introduced by #14469
Angular creates an empty comment here

@tbosch do you know why it was required?

@teabagp
Copy link
Author

teabagp commented Mar 14, 2017

Give advice on how best to get rid of comment?

@DzmitryShylovich
Copy link
Contributor

@teabagp for example like this http://plnkr.co/edit/FANAd3wPtqrKoTdxG2c5?p=preview

but you should really avoid direct dom manipulations. why do you need a component with an empty template? maybe directive would be better?

@IgorMinar IgorMinar added area: core Issues related to the framework runtime regression Indicates than the issue relates to something that worked in a previous version type: bug/fix labels Mar 14, 2017
@IgorMinar IgorMinar added this to the 4.0.0-blocker-candidates milestone Mar 14, 2017
@tbosch tbosch modified the milestones: 4.0.0-blockers, 4.0.0-blocker-candidates Mar 15, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime regression Indicates than the issue relates to something that worked in a previous version type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants