AST.toString() === 'AST'?

[matthewjh]

Is there any particular reason why subclasses of AST do not override the 'abstract' AST implementation of toString?

For this reason, change detection errors that use ProtoRecord#expressionAsString, which is derived from bindingRecord.ast.toString() throw unhelpful, garbage errors like this:

Expression 'AST' has changed after it was checked. Previous value: ''. Current value: ''

[matthewjh]

Actually, it'd probably be better to simply get the expression string from the upstream ASTWithSource, and pass it in to the BindingRecord constructor (which would assign it to a property astSource for example), rather than unnecessarily computing it from the AST.

Thoughts? Any reason why this wouldn't work / is a bad idea?

[matthewjh]

What do you think, @vicb?

[vicb]

I'm not sure if AST.toString() is really valuable here, we should probably have a visitor that could transform an AST back to an expression.

BindingRecord takes an AST so it might not be an ASTWithSource.

@vsavkin what do you think ?

[vsavkin]

I think the issue was fixed some time ago. @vicb can you reproduce it on master?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}