Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(animations): always fire inner trigger callbacks even if blocked by parent animations #19753

Closed
wants to merge 1 commit into from
Closed

fix(animations): always fire inner trigger callbacks even if blocked by parent animations #19753

wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Oct 16, 2017

Closes #19100

@mary-poppins
Copy link

You can preview f50f537 at https://pr19753-f50f537.ngbuilds.io/.

@matsko matsko mentioned this pull request Oct 17, 2017
Closed
mhevery
mhevery approved these changes Oct 17, 2017
View reviewed changes
packages/animations/browser/src/render/transition_animation_engine.ts Outdated
syncPlayerEvents(player: AnimationPlayer) {
const p = this._player as any;
if (p.triggerCallback) {
player.onStart(() => p.triggerCallback !('start'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove !

@matsko matsko force-pushed the fix_parent_animation_detection branch from f50f537 to bc92c79 Compare October 17, 2017 20:14
@matsko matsko added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 17, 2017
@mary-poppins
Copy link

You can preview bc92c79 at https://pr19753-bc92c79.ngbuilds.io/.

@tbosch tbosch added this to the Merge-queue milestone Oct 17, 2017
@tbosch tbosch closed this in 5a9ed2d Oct 18, 2017
tbosch added a commit to tbosch/angular that referenced this pull request Oct 18, 2017
@tbosch
Revert "fix(animations): always fire inner trigger callbacks even if …
18bbf2b 
…blocked by parent animations (angular#19753)"

This reverts commit 5a9ed2d.
tbosch added a commit that referenced this pull request Oct 18, 2017
@tbosch
Revert "fix(animations): always fire inner trigger callbacks even if …
8d735da 
…blocked by parent animations (#19753)"

This reverts commit 5a9ed2d.
As it broke an internal test.
@tbosch tbosch reopened this Oct 18, 2017
@mary-poppins
Copy link

You can preview bc92c79 at https://pr19753-bc92c79.ngbuilds.io/.

@tbosch tbosch removed the action: merge The PR is ready for merge by the caretaker label Oct 18, 2017
@tbosch
Copy link
Contributor

tbosch commented Oct 18, 2017

This broke a test in G3.

This was referenced Oct 26, 2017
Open
Open
Closed
@fxck
Copy link

fxck commented Oct 29, 2017

@tbosch any chance this will get in before angular 5 final? It's a requirement for #19455 without which nested animations are pretty much broken..

@matsko matsko removed this from the Merge-queue milestone Nov 1, 2017
@matsko matsko closed this Nov 10, 2017
@matsko matsko force-pushed the fix_parent_animation_detection branch from bc92c79 to 9bcd709 Compare November 10, 2017 07:49
@matsko matsko reopened this Nov 10, 2017
@mary-poppins
Copy link

You can preview c260a65 at https://pr19753-c260a65.ngbuilds.io/.

@matsko matsko force-pushed the fix_parent_animation_detection branch from c260a65 to 7cdd829 Compare November 13, 2017 19:17
@mary-poppins
Copy link

You can preview 7cdd829 at https://pr19753-7cdd829.ngbuilds.io/.

@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Nov 14, 2017
@jasonaden jasonaden closed this in d47b2a6 Nov 15, 2017
jasonaden pushed a commit that referenced this pull request Nov 15, 2017
@matsko @jasonaden
fix(animations): always fire inner trigger callbacks even if blocked …
bc4b4b5 
…by parent animations (#19753)

Closes #19100

PR Close #19753
mhevery added a commit that referenced this pull request Nov 16, 2017
@mhevery
Revert "fix(animations): always fire inner trigger callbacks even if …
f8658cd 
…blocked by parent animations (#19753)"

This reverts commit d47b2a6.
mhevery added a commit that referenced this pull request Nov 16, 2017
@mhevery
Revert "fix(animations): always fire inner trigger callbacks even if …
d5eaf4d 
…blocked by parent animations (#19753)"

This reverts commit bc4b4b5.
@matpag
Copy link

matpag commented Nov 17, 2017 •
edited

@mhevery This PR seems to have been reverted but it is listed in the current changelog for the 5.1.0-beta1 release. Am I missing something?

mhevery pushed a commit that referenced this pull request Nov 18, 2017
@matsko @mhevery
fix(animations): always fire inner trigger callbacks even if blocked …
814f062 
…by parent animations (#19753)

Closes #19100

PR Close #19753
mhevery pushed a commit that referenced this pull request Nov 22, 2017
@matsko @mhevery
fix(animations): always fire inner trigger callbacks even if blocked …
0e012c9 
…by parent animations (#19753)

Closes #19100

PR Close #19753
wKoza pushed a commit to wKoza/angular that referenced this pull request Dec 2, 2017
@matsko @wKoza
fix(animations): always fire inner trigger callbacks even if blocked …
c34996d 
…by parent animations (angular#19753)

Closes angular#19100

PR Close angular#19753
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: animations cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested animation don't run and start callback is not fired
8 participants
@matsko @mary-poppins @tbosch @fxck @matpag @mhevery @jasonaden @googlebot