transpiler: show line numbers that have errors #1

tbosch · 2014-09-19T23:23:12Z

E.g. error from writing method(String s) (which should be method(s:string))

The text was updated successfully, but these errors were encountered:

vicb · 2014-10-02T10:02:18Z

You can achieve this by using the error reporter in the transformer, ie this.reporter.reportError(location, msg);
location can be retrieved from the parse tree

vojtajina · 2014-11-05T19:42:51Z

I just tried this with the Karma setup. This fails Traceur compilation and does not even run the tests. The output shows line numbers and errors:

INFO [watcher]: Changed file "/Users/vojta/Code/angular/modules/core/src/compiler/compiler.js".
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:11:24: Unexpected token templateLoader
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:11:38: Unexpected token )
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:20: Unexpected token :
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:21: Semi-colon expected
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:34: Semi-colon expected
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:34: Unexpected token :
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:35: Semi-colon expected
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:53: Semi-colon expected
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:53: Unexpected token )
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:54: Semi-colon expected
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:54: Unexpected token :
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:55: Semi-colon expected
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:78: Semi-colon expected
ERROR [traceur]: /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:29:1: Unexpected token End of File
Chrome 40.0.2210 (Mac OS X 10.9.5) ERROR
  TEST RUN WAS CANCELLED because this file contains some errors:
    /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js

I also improved the way gulp shows the errors (see 7d0a83a). Now it looks like this:

Error: gulp-traceur:
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:11:24: Unexpected token templateLoader
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:11:38: Unexpected token )
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:20: Unexpected token :
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:21: Semi-colon expected
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:34: Semi-colon expected
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:34: Unexpected token :
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:35: Semi-colon expected
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:53: Semi-colon expected
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:53: Unexpected token )
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:54: Semi-colon expected
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:54: Unexpected token :
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:55: Semi-colon expected
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:23:78: Semi-colon expected
  /Users/vojta/Code/angular/modules/core/src/compiler/compiler.js:29:1: Unexpected token End of File

Please re-open if you have any suggestions how to make it better.

rebuild based on most current angular 2 on npm

This fixes the following type error that is thrown when calling getAllAngularTestability() while running Dartium in checked mode: type 'MappedListIterable' is not a subtype of type 'List<PublicTestability>' of 'publicTestabilities'. #0 GetTestability.addToWindow.<anonymous closure> (package:angular2/src/core/testability/get_testability.dart:92:12) #1 Function._apply (dart:core-patch/function_patch.dart:7) angular#2 Function.apply (dart:core-patch/function_patch.dart:28) angular#3 __invokeFn (package:angular2/src/core/testability/get_testability.dart:26:26) angular#4 _jsFunction.<anonymous closure> (package:angular2/src/core/testability/get_testability.dart:15:12)

These tests validate the ability of the View Engine TestBed to consume summary metadata, a mechanism which allows the TestBed to use AOT-compiled components & directives in tests. It achieves this through two operations which are independently obsolete in Ivy: 1. It injects CompileMetadataResolver, a View Engine specific compiler internal class which extracts global analysis metadata from classes, and uses it to construct summary metadata. This happens in a beforeEach() block which calls createSummaries(). 2. It uses TestBed.initTestEnvironment to pass summary metadata to the TestBed itself. Any such metadata is ignored in Ivy. Operation #1 makes it impossible to run these tests under Ivy, as the CompileMetadataResolver is not available with an Ivy compiler. Ivy itself does not rely on summary data, and the R3TestBed can depend directly on AOT compiled components without it. Thus, the spirit of thes tests is obsolete in an Ivy world. FW-838 #resolve

…8027) These tests validate the ability of the View Engine TestBed to consume summary metadata, a mechanism which allows the TestBed to use AOT-compiled components & directives in tests. It achieves this through two operations which are independently obsolete in Ivy: 1. It injects CompileMetadataResolver, a View Engine specific compiler internal class which extracts global analysis metadata from classes, and uses it to construct summary metadata. This happens in a beforeEach() block which calls createSummaries(). 2. It uses TestBed.initTestEnvironment to pass summary metadata to the TestBed itself. Any such metadata is ignored in Ivy. Operation #1 makes it impossible to run these tests under Ivy, as the CompileMetadataResolver is not available with an Ivy compiler. Ivy itself does not rely on summary data, and the R3TestBed can depend directly on AOT compiled components without it. Thus, the spirit of thes tests is obsolete in an Ivy world. FW-838 #resolve PR Close #28027

Prior to this change the postprocess step relied on the order of placeholders combined in one group (e.g. [�#1�|�*1:1�]). The order is not guaranteed in case we have nested templates (since we use BFS to process templates) and some tags are represented using same placeholders. This change performs postprocessing more accurate by keeping track of currently active template and searching for matching placeholder.

) Prior to this change the postprocess step relied on the order of placeholders combined in one group (e.g. [�#1�|�*1:1�]). The order is not guaranteed in case we have nested templates (since we use BFS to process templates) and some tags are represented using same placeholders. This change performs postprocessing more accurate by keeping track of currently active template and searching for matching placeholder. PR Close #28209

…gular#28027) These tests validate the ability of the View Engine TestBed to consume summary metadata, a mechanism which allows the TestBed to use AOT-compiled components & directives in tests. It achieves this through two operations which are independently obsolete in Ivy: 1. It injects CompileMetadataResolver, a View Engine specific compiler internal class which extracts global analysis metadata from classes, and uses it to construct summary metadata. This happens in a beforeEach() block which calls createSummaries(). 2. It uses TestBed.initTestEnvironment to pass summary metadata to the TestBed itself. Any such metadata is ignored in Ivy. Operation angular#1 makes it impossible to run these tests under Ivy, as the CompileMetadataResolver is not available with an Ivy compiler. Ivy itself does not rely on summary data, and the R3TestBed can depend directly on AOT compiled components without it. Thus, the spirit of thes tests is obsolete in an Ivy world. FW-838 #resolve PR Close angular#28027

…ular#28209) Prior to this change the postprocess step relied on the order of placeholders combined in one group (e.g. [�angular#1�|�*1:1�]). The order is not guaranteed in case we have nested templates (since we use BFS to process templates) and some tags are represented using same placeholders. This change performs postprocessing more accurate by keeping track of currently active template and searching for matching placeholder. PR Close angular#28209

angular-automatic-lock-bot · 2019-09-05T19:21:11Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

tbosch changed the title ~~Build: show line numbers that have errors~~ build: show line numbers that have errors Sep 29, 2014

tbosch changed the title ~~build: show line numbers that have errors~~ transpiler: show line numbers that have errors Sep 29, 2014

tbosch added the component: transpiler label Sep 29, 2014

mhevery modified the milestone: October Sep 29, 2014

mhevery added the ready label Oct 14, 2014

naomiblack modified the milestones: AtScript M1: Nice Dev Environment, M1: HelloWorld Oct 14, 2014

naomiblack added ready and removed ready labels Oct 14, 2014

vojtajina closed this as completed Nov 5, 2014

vojtajina removed the ready label Nov 5, 2014

SanderElias mentioned this issue Nov 11, 2014

RFC: <proposal #someId [bind]="expr" (event)="doWork()"> #133

Closed

jcoyne pushed a commit to jcoyne/angular that referenced this issue Apr 12, 2015

Merge pull request angular#1 from angular/update

d7c5874

rebuild based on most current angular 2 on npm

harryterkelsen mentioned this issue May 6, 2015

naive_infinite_scroll benchmark occasionally times out with JS #1706

Closed

jbdeboer mentioned this issue May 27, 2015

Ability to stop event propogation #2042

Closed

This was referenced May 29, 2015

Interface-based lifecycle methods #2120

Closed

Interface based lifecycle methods #2220

Closed

kzhdev mentioned this issue Jun 13, 2015

5 min quick start for Dart does not work. #2532

Closed

This was referenced Jun 18, 2015

Transformer hangs when invalid templateUrl is used #2605

Closed

@import style urls in a template throw a cryptic NPE #2611

Closed

dsebastien mentioned this issue Jul 2, 2015

Compile all components to one JS file #2850

Closed

waleedarshad mentioned this issue Jul 15, 2015

Unknown provider: $$qProvider <- $$q <- $animate <- $compile <- $modalStack #3064

Closed

avoivo mentioned this issue Jul 31, 2015

(dart) using routerDirectives on view annotation, crashes on browser #3387

Closed

yjbanov mentioned this issue Aug 1, 2015

Develop a linter that looks for non-prod code in dart2js output #3440

Closed

pkozlowski-opensource mentioned this issue Aug 3, 2015

DI: Stack trace is lost when a binding is failed to be created #3408

Closed

goderbauer mentioned this issue Aug 7, 2015

fix(testability): fix type error in getAllAngularTestability (dart) #3522

Closed

gregmagolan mentioned this issue May 28, 2018

Fix bazel es5 ngfactory files with secondary angular entry-point imports #24170

Closed

3 tasks

jenniferfell mentioned this issue Jun 8, 2018

provide more cues for deprecated APIs #24380

Closed

marc-wilson mentioned this issue Aug 7, 2018

Leverage Guards to Hide/Display Content #25342

Closed

AbakumovAlexandr mentioned this issue Aug 8, 2018

(feature): Ability to pass a default value with @Optional() #25395

Open

mlc-mlapis mentioned this issue Aug 10, 2018

missing renavigate method at new angular-router #9669

Closed

dirkluijk mentioned this issue Aug 31, 2018

Router: new Redirect guard proposal #25773

Closed

gkalpak mentioned this issue Oct 8, 2018

WIP: docs(tutorial): fix url inconsistency in tutorial chapters #24628

Closed

3 tasks

Airblader mentioned this issue Nov 20, 2018

Perhaps Router Resolve shouldn't wait for Observable to Complete? #10556

Closed

alxhub mentioned this issue Nov 26, 2018

AOT compilation error in 7.1.0: export 'InjectFlags' was not found in '@angular/core' #27251

Closed

alfaproject mentioned this issue Dec 29, 2018

refactor(router): subscribe router events until destroyed #27842

Closed

14 tasks

alxhub mentioned this issue Jan 9, 2019

test(ivy): mark jit_summaries_integration_spec as obsolete in Ivy #28027

Closed

AndrewKushnir mentioned this issue Jan 17, 2019

fix(ivy): proper i18n postprocessing in case of nested templates #28209

Closed

3 tasks

MaverickH mentioned this issue Jan 23, 2019

route redirectTo not preserving query params #13315

Closed

subodhkumar mentioned this issue Jan 30, 2019

Compiler Metadata fetch causes error in Prod/AOT Build.. #28272

Closed

DeborahK mentioned this issue Feb 7, 2019

docs: take out coremodule references #28434

Closed

14 tasks

johnpapa mentioned this issue Apr 15, 2019

Keep CoreModule as preferred location for app-wide single-use components #29848

Closed

alxhub mentioned this issue Jun 6, 2019

Allow to use SSR pages when online, and fallback to cached index.html when offline #30861

Closed

kara mentioned this issue Jun 18, 2019

perf(ivy): chain multiple property instructions #31078

Closed

alxhub mentioned this issue Jul 2, 2019

Ngcc perf improvements #30525

Closed

kara mentioned this issue Jul 10, 2019

fix(ivy): incorrect ChangeDetectorRef injected into pipes used in component inputs #31438

Closed

JohannesHoppe mentioned this issue Aug 29, 2019

HTTP_INTERCEPTORS are reset when a lazy loaded module imports another module importing HttpClientModule #20575

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

transpiler: show line numbers that have errors #1

transpiler: show line numbers that have errors #1

tbosch commented Sep 19, 2014

vicb commented Oct 2, 2014

vojtajina commented Nov 5, 2014

angular-automatic-lock-bot bot commented Sep 5, 2019

transpiler: show line numbers that have errors #1

transpiler: show line numbers that have errors #1

Comments

tbosch commented Sep 19, 2014

vicb commented Oct 2, 2014

vojtajina commented Nov 5, 2014

angular-automatic-lock-bot bot commented Sep 5, 2019