Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp test.unit.js - broken #2054

Closed
vicb opened this issue May 21, 2015 · 11 comments
Closed

gulp test.unit.js - broken #2054

vicb opened this issue May 21, 2015 · 11 comments

Comments

@vicb
Copy link
Contributor

vicb commented May 21, 2015

on master 863eb3c

The first run is ok.

Then:

  • No more progress traces are displayed after a file changes (the tests re-run but no progress / error reported), see traces below,
  • Sometimes a second browser window gets opened ?

linked to the de-dedup of the logs & different processes ?

[11:01:39] Finished '!broccoli.js.dev' after 1.93 s
[11:01:39] Starting '!test.unit.js/karma-run'...
[11:01:40] Finished '!test.unit.js/karma-run' after 270 ms
[11:02:46] Starting '!broccoli.js.dev'...
Tree diff:          funnel-output_path-u7JTbQRS.tmp, duration:    51ms,     1 changes detected (files:   251, directories:  221) [
  * angular2/test/core/compiler/element_injector_spec.js
]
Tree diff:          funnel-output_path-u7JTbQRS.tmp, duration:    29ms,     0 changes detected (files:   128, directories:  221)
Tree diff:                   funnel-dest_9MaEXB.tmp, duration:    30ms,     1 changes detected (files:   379, directories:  123) [
  * angular2/test/core/compiler/element_injector_spec.es6
]
Tree diff:                   funnel-dest_rmC7Kc.tmp, duration:    74ms,     4 changes detected (files:  2009, directories:  252) [
  * es5/angular2/test/core/compiler/element_injector_spec.js
  * es5/angular2/test/core/compiler/element_injector_spec.js.map
  * es6/angular2/test/core/compiler/element_injector_spec.es6
  * es6/angular2/test/core/compiler/element_injector_spec.map
]

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
Funnel                                        | 637ms               
Funnel                                        | 467ms               
DiffingTraceurCompiler                        | 250ms               
DiffingTraceurCompiler                        | 207ms               
TreeMerger                                    | 180ms               
TreeMerger                                    | 165ms               
ReplaceFilter                                 | 135ms               

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
Funnel (74)                                   | 1337ms (18 ms)      
DiffingTraceurCompiler (2)                    | 457ms (228 ms)      
TreeMerger (7)                                | 405ms (57 ms)       
ReplaceFilter (3)                             | 238ms (79 ms)       

[11:02:49] Finished '!broccoli.js.dev' after 2.56 s
[11:02:49] Starting '!test.unit.js/karma-run'...
[11:02:49] Finished '!test.unit.js/karma-run' after 246 ms
<<< Where are my test progress ??? >>>
@vicb
Copy link
Contributor Author

vicb commented May 21, 2015

should we have a test suite for the test suite (that wouldn't use the test suite) ?

@PatrickJS
Copy link
Member

@vicb
Copy link
Contributor Author

vicb commented May 21, 2015

Tried to revert all commits up to the different process -> no success
Tried to revert the protractor/jasmine update -> no success

The other thing I can think of is a fresh npm i I did yesterday. It was working before

@tbosch
Copy link
Contributor

tbosch commented May 21, 2015

Please ping Igor, he was working on a fix
On Thu, May 21, 2015 at 2:53 AM Victor Berchet notifications@github.com
wrote:

Tried to revert all commits up to the different process -> no success
Tried to revert the protractor/jasmine update -> no success

The other thing I can think of is a fresh npm i I did yesterday. It was
working before


Reply to this email directly or view it on GitHub
#2054 (comment).

@vicb
Copy link
Contributor Author

vicb commented May 21, 2015

ping @IgorMinar

@IgorMinar
Copy link
Contributor

I'm in meeting, I'll look into this in a few hours. is this reproducable by others?

@IgorMinar IgorMinar added this to the M9: TypeScript and Build Stability milestone May 21, 2015
@caitp
Copy link
Contributor

caitp commented May 21, 2015

@marclaval
Copy link
Contributor

Same issue on my Windows laptop.

In addition, '!broccoli.js.dev'task is run twice after launching gulp test.unit.js, and each run takes 40-50s ... For info, it is even slower on a MBP from 2011.
Is anyone experiencing such slowness ?

@IgorMinar
Copy link
Contributor

@vicb I tried to repro this, but wasn't successful. are you still seeing this issue? can we pair tomorrow morning. I'm free between 9 and 10am PDT.

@Mlaval can you create a separate issue about the slowness and post the output log into the issue?

@vicb
Copy link
Contributor Author

vicb commented May 22, 2015

So happy that I can close this issue this morning (it works for me now). THANKS !!!

@vicb vicb closed this as completed May 22, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants