-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router should not mutate Route config objects because it causes issue with platform-server #22203
Comments
Hi, |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a...
Current behavior
Router mutates Route[] object created by the user and configure in NgModule by writing extra _loadedConfig field.
This is ok for platform-browser by not for platform-server where parallel requests are sharing the same Route[] object.
Expected behavior
Router should create a copy of the Route config per application before mutating it.
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
This is to make sure Router works properly on the server environment
Environment
The text was updated successfully, but these errors were encountered: