Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ivy): remove unnecessary binding from hello world #22848

Closed
wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Mar 17, 2018

This PR removes the binding from HelloWorld bundle.

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy target: major This PR is targeted for the next major release labels Mar 17, 2018
@kara kara requested a review from mhevery March 17, 2018 18:54
@kara kara force-pushed the bundle branch 3 times, most recently from 05dc3ce to 84d73d1 Compare March 17, 2018 19:13
@mary-poppins
Copy link

You can preview 84d73d1 at https://pr22848-84d73d1.ngbuilds.io/.

@angular angular deleted a comment from mary-poppins Mar 17, 2018
@angular angular deleted a comment from mary-poppins Mar 17, 2018
@mary-poppins
Copy link

You can preview c3b859b at https://pr22848-c3b859b.ngbuilds.io/.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 19, 2018
@mhevery mhevery closed this in 1a0cb21 Mar 19, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants