-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit dependencies for angular2 in package.json #2448
Comments
So, I totally agree that we should be more strict about what we put in the https://github.com/angular/angular/blob/master/package.json file, but my understanding is that the package.json that gets pushed to npm is generated from https://github.com/angular/angular/blob/master/modules/angular2/package.json |
Yes, this is correct
|
@pkozlowski-opensource Right, so technically the top level The only other case where it matters would be if someone uses |
Hey everyone, i would not mind taking care of this minor issue, we just need to move certain dependencies like gulp-insert from runtime dependencies to to dev dependencies in the https://github.com/angular/angular/blob/master/package.json file correct? |
I have never contributed to Angular before so this looks like a nice, super easy issue to start with. Ive used angularJS 1.3 and now 1.4 for about a year at work, so i have experience using AngularJS and i have messed around and done some little personal projects using Angular and am loving it even more than i love AngularJS. |
Go for it, make sure to read https://github.com/angular/angular/blob/master/npm-shrinkwrap.readme.md I don't plan to work on this before the end of the week, but if it is still open before the next alpha, I will handle it myself. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently we are listing obvious dev dependencies like
gulp-insert
as runtime dependencies./cc @robwormald @pkozlowski-opensource
The text was updated successfully, but these errors were encountered: