Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit dependencies for angular2 in package.json #2448

Closed
rkirov opened this issue Jun 9, 2015 · 7 comments · Fixed by #2964
Closed

Audit dependencies for angular2 in package.json #2448

rkirov opened this issue Jun 9, 2015 · 7 comments · Fixed by #2964
Assignees
Milestone

Comments

@rkirov
Copy link
Contributor

rkirov commented Jun 9, 2015

Currently we are listing obvious dev dependencies like gulp-insert as runtime dependencies.

/cc @robwormald @pkozlowski-opensource

@rkirov rkirov added this to the alpha-27 milestone Jun 9, 2015
@pkozlowski-opensource
Copy link
Member

So, I totally agree that we should be more strict about what we put in the https://github.com/angular/angular/blob/master/package.json file, but my understanding is that the package.json that gets pushed to npm is generated from https://github.com/angular/angular/blob/master/modules/angular2/package.json

@tbosch
Copy link
Contributor

tbosch commented Jun 10, 2015

Yes, this is correct
On Wed, Jun 10, 2015 at 7:46 AM Pawel Kozlowski notifications@github.com
wrote:

So, I totally agree that we should be more strict about what we put in the
https://github.com/angular/angular/blob/master/package.json file, but my
understanding is that the package.json that gets pushed to npm is generated
from
https://github.com/angular/angular/blob/master/modules/angular2/package.json


Reply to this email directly or view it on GitHub
#2448 (comment).

@rkirov
Copy link
Contributor Author

rkirov commented Jun 10, 2015

@pkozlowski-opensource Right, so technically the top level package.json can never be used as a dependency to other projectes since it is never published to npm.

The only other case where it matters would be if someone uses jspm github:angular/angular.

@jgw96
Copy link

jgw96 commented Jun 22, 2015

Hey everyone, i would not mind taking care of this minor issue, we just need to move certain dependencies like gulp-insert from runtime dependencies to to dev dependencies in the https://github.com/angular/angular/blob/master/package.json file correct?

@jgw96
Copy link

jgw96 commented Jun 22, 2015

I have never contributed to Angular before so this looks like a nice, super easy issue to start with. Ive used angularJS 1.3 and now 1.4 for about a year at work, so i have experience using AngularJS and i have messed around and done some little personal projects using Angular and am loving it even more than i love AngularJS.

@rkirov rkirov modified the milestones: alpha-29, alpha-28 Jun 22, 2015
@rkirov
Copy link
Contributor Author

rkirov commented Jun 22, 2015

Go for it, make sure to read https://github.com/angular/angular/blob/master/npm-shrinkwrap.readme.md

I don't plan to work on this before the end of the week, but if it is still open before the next alpha, I will handle it myself.

@naomiblack naomiblack modified the milestones: alpha-29, alpha-31 Jun 30, 2015
rkirov added a commit to rkirov/angular that referenced this issue Jul 9, 2015
rkirov added a commit to rkirov/angular that referenced this issue Jul 9, 2015
jteplitz pushed a commit to jteplitz/angular that referenced this issue Jul 14, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants