Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.dart expected errors ? #2454

Closed
vicb opened this issue Jun 10, 2015 · 6 comments
Closed

build.dart expected errors ? #2454

vicb opened this issue Jun 10, 2015 · 6 comments

Comments

@vicb
Copy link
Contributor

vicb commented Jun 10, 2015

on master: https://travis-ci.org/angular/angular/jobs/66142657#L650

are those expected ?

/cc @kegluneq

@kegluneq
Copy link

These errors are coming from package:di, which is the original Angular.dart's DI code. I believe that is being brought in by benchmarking code to compare angular2 vs. angular.dart performance.

I don't know whether they are expected or not.

@vicb
Copy link
Contributor Author

vicb commented Jun 10, 2015

It seems like those are recent, I've first noticed them on your PR
https://travis-ci.org/angular/angular/jobs/66138141
There were not on alpha.26
https://travis-ci.org/angular/angular/jobs/65336394

(Not saying your PR is the root cause. Only adding refs for further investigations - could it linked to a dependency update ?)

@kegluneq
Copy link

I'm guessing b2596dd is the culprit, it adds empty .dart files and the errors sound correct to that situation.

Here is the build log for that commit with errors present: https://travis-ci.org/angular/angular/jobs/65435790#L652
and the same area in the commit before with no errors: https://travis-ci.org/angular/angular/jobs/65416977#L643

You probably know more about package:di than I do -- any idea why empty dart files might cause this situation?

@vicb
Copy link
Contributor Author

vicb commented Jun 10, 2015

Thanks for the analysis.

Might be because the transformers look for DI related code in the main or because there are multiple main. I'll take a look later this week.

@kegluneq
Copy link

Looks like this is a duplicate of #2380

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants