-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Angular Elements]: Adding ComponentNgElementStrategyFactory & ComponentNgElementStrategy to public API #26112
Comments
This would be useful. While waiting for the zone changes to land, I had to do some hacky things to be able to wrap ComponentNgElementStrategy. See elements-zone-strategy |
Adds ComponentNgElementStrategy, ComponentNgElementStrategyFactory to the public API, allowing third-party libraries to extend the default strategy behavior Fixes angular#26112, angular#33490
We need this to workaround the issue mentioned in #29606 |
We have decided to not make If you need to define your own strategy, you can copy |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a...
Current behavior
On implementing an optional custom strategy provider, when I create a new custom element with an angular component, I am forced to implement a complete new custom strategy provider with an own factory.
Expected behavior
But if I want to hook up a custom behavior to the default ComponentNgElementStrategy, I have to copy&paste the default class. Maybe it would be better, to import the default class that the custom element strategy could inherit from the default one.
Minimal reproduction of the problem with instructions
I have pushed an angular elements example with a custom behavior hooked up into the default copied and pasted ComponentNgElementStrategy on the connect method:
https://github.com/jKelio/angular-element-example
What is the motivation / use case for changing the behavior?
Avoiding too much coping&pasting stuff from the angular framework itself.
Environment
The text was updated successfully, but these errors were encountered: