Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular docs: Suggest es7/array polyfill for hash-based routing #26511

Closed
rmorrise opened this issue Oct 17, 2018 · 2 comments
Closed

Angular docs: Suggest es7/array polyfill for hash-based routing #26511

rmorrise opened this issue Oct 17, 2018 · 2 comments

Comments

@rmorrise
Copy link

I'm submitting a...


[x] Documentation issue or request

Current behavior

Using hash-based routing strategy in IE11, angular throws an error:
IE11 - Object doesn't support property or method 'includes' - javascript window.location.hash

The solution is to add the es7/array polyfill to polyfills.ts:
https://stackoverflow.com/a/52630710/166850

Expected behavior

Please add this polyfill to the table of polyfills in the Angular documentation.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: 6.0.0


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [x] IE version 11
- [ ] Edge version XX
 
Others:

@jenniferfell
Copy link
Contributor

@ngbot ngbot bot modified the milestones: needsTriage, Backlog Oct 25, 2018
@brandonroberts brandonroberts self-assigned this Nov 13, 2018
brandonroberts added a commit to brandonroberts/angular that referenced this issue Nov 16, 2018
brandonroberts added a commit to brandonroberts/angular that referenced this issue Jan 7, 2019
brandonroberts added a commit to brandonroberts/angular that referenced this issue Jan 8, 2019
brandonroberts added a commit to brandonroberts/angular that referenced this issue Jan 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants