feat: add support for typescript 3.2 #27536

@@ -8,6 +8,8 @@
 import {dirname} from 'canonical-path';
 import {existsSync, writeFileSync} from 'fs';
 import {mkdir, mv} from 'shelljs';
+// "unused" import needed by tsc type inference
+import * as ts from 'typescript';


I think this is required by the return type of Transformer.analyzeProgram being inferred (and the inferred type including TS types). If you make that return type explicit, this statement won't appear unused.

mary-poppins · 2018-12-15T01:31:16Z

You can preview a6e6763 at https://pr27536-a6e6763.ngbuilds.io/.

IgorMinar · 2018-12-15T02:08:51Z

https://test.corp.google.com/ui#id=OCL:225629145:BASE:225632835:1544839712303:80c11cce

mary-poppins · 2018-12-17T07:09:04Z

You can preview 00e0894 at https://pr27536-00e0894.ngbuilds.io/.

alfaproject · 2018-12-17T12:26:00Z

aio/src/app/custom-elements/elements-loader.ts

 import { createCustomElement } from '@angular/elements';

+// huh? not sure why, but ts 3.2 emits broken code for: `import { from as fromPromise, ...} from 'rxjs';
+// this const alias works around the problem.
+const fromPromise = from;


Why not update the references to not use the alias?

that's what I'll do for now, I just wanted to get more people to take a look at this because import as should work and shouldn't break with a typescript update.

I filed angular/angular-cli#13212 to track this.

IgorMinar · 2018-12-18T07:17:22Z

caretaker note: pullapprove and travis flaked

…al (#27536) Typescript 3.2 introduced BigInt type, and consequently the implementation for checkExpressionWorker() in checkers.ts is refactored. For NumberLiteral and StringLiteral types, 'text' filed must be present in the Node type, therefore they must be LiteralLikeNode instead of Node. PR Close #27536

It's unclear why `import as` results in the aliases to be undefined. Plain tsc seems to do the right thing and emits the correct code, so it might be some kind of interaction in @angular/cli or webpack that are causing the failure. This should be investigated separately from the tsc update in angular/angular. See angular/angular-cli#13212 PR Close #27536

PR Close #27536

…27536) cli is not yet officially compatible with typescript 3.2, so we need to disable the version check via: ng config cli.warnings.typescriptMismatch false PR Close #27536

…mpilerOptions (#27536) We need to do this because we don't yet have a released version of angular with typescript 3.2 support and on CI we test both against the snapshot and whatever is in aio/yarn.lock. Once we have the next rc or a stable relase we should be able to remove this flag. PS: I also removed the preserveWhitespace:false because that's the default now. PR Close #27536

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-2.html https://blogs.msdn.microsoft.com/typescript/2018/11/29/announcing-typescript-3-2/ Any application using tsickle for closure compatibility will need to update it's tsickle dependency to 0.34 PR Close angular#27536

…al (angular#27536) Typescript 3.2 introduced BigInt type, and consequently the implementation for checkExpressionWorker() in checkers.ts is refactored. For NumberLiteral and StringLiteral types, 'text' filed must be present in the Node type, therefore they must be LiteralLikeNode instead of Node. PR Close angular#27536

It's unclear why `import as` results in the aliases to be undefined. Plain tsc seems to do the right thing and emits the correct code, so it might be some kind of interaction in @angular/cli or webpack that are causing the failure. This should be investigated separately from the tsc update in angular/angular. See angular/angular-cli#13212 PR Close angular#27536

…#27536) PR Close angular#27536

…ngular#27536) cli is not yet officially compatible with typescript 3.2, so we need to disable the version check via: ng config cli.warnings.typescriptMismatch false PR Close angular#27536

…mpilerOptions (angular#27536) We need to do this because we don't yet have a released version of angular with typescript 3.2 support and on CI we test both against the snapshot and whatever is in aio/yarn.lock. Once we have the next rc or a stable relase we should be able to remove this flag. PS: I also removed the preserveWhitespace:false because that's the default now. PR Close angular#27536

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-2.html https://blogs.msdn.microsoft.com/typescript/2018/11/29/announcing-typescript-3-2/ Any application using tsickle for closure compatibility will need to update it's tsickle dependency to 0.34 PR Close angular#27536

…al (angular#27536) Typescript 3.2 introduced BigInt type, and consequently the implementation for checkExpressionWorker() in checkers.ts is refactored. For NumberLiteral and StringLiteral types, 'text' filed must be present in the Node type, therefore they must be LiteralLikeNode instead of Node. PR Close angular#27536

It's unclear why `import as` results in the aliases to be undefined. Plain tsc seems to do the right thing and emits the correct code, so it might be some kind of interaction in @angular/cli or webpack that are causing the failure. This should be investigated separately from the tsc update in angular/angular. See angular/angular-cli#13212 PR Close angular#27536

…#27536) PR Close angular#27536

…ngular#27536) cli is not yet officially compatible with typescript 3.2, so we need to disable the version check via: ng config cli.warnings.typescriptMismatch false PR Close angular#27536

…mpilerOptions (angular#27536) We need to do this because we don't yet have a released version of angular with typescript 3.2 support and on CI we test both against the snapshot and whatever is in aio/yarn.lock. Once we have the next rc or a stable relase we should be able to remove this flag. PS: I also removed the preserveWhitespace:false because that's the default now. PR Close angular#27536

zw-slime · 2019-01-09T03:43:06Z

Package "ng-zorro-antd" has an incompatible peer dependency to "typescript" (requires "~3.1.1", would install "3.2.2").

I can not update ngrx to 7.0.0, please help, when can support typescript 3.2?

IgorMinar · 2019-01-09T06:36:42Z

angular framework 7.2 has been released on Monday with typescript 3.2 support: https://github.com/angular/angular/blob/master/CHANGELOG.md#720-2019-01-07

…

On Tue, Jan 8, 2019 at 7:43 PM zw ***@***.***> wrote: Package "ng-zorro-antd" has an incompatible peer dependency to "typescript" (requires "~3.1.1", would install "3.2.2"). I can not update ngrx to 7.0.0, please help, when can support typescript 3.2? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27536 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6Ml2VMukiLU4yMdn32KtZ867HHlhks5vBWVPgaJpZM4ZH6Eb> .

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-2.html https://blogs.msdn.microsoft.com/typescript/2018/11/29/announcing-typescript-3-2/ Any application using tsickle for closure compatibility will need to update it's tsickle dependency to 0.34 PR Close angular#27536

…al (angular#27536) Typescript 3.2 introduced BigInt type, and consequently the implementation for checkExpressionWorker() in checkers.ts is refactored. For NumberLiteral and StringLiteral types, 'text' filed must be present in the Node type, therefore they must be LiteralLikeNode instead of Node. PR Close angular#27536

It's unclear why `import as` results in the aliases to be undefined. Plain tsc seems to do the right thing and emits the correct code, so it might be some kind of interaction in @angular/cli or webpack that are causing the failure. This should be investigated separately from the tsc update in angular/angular. See angular/angular-cli#13212 PR Close angular#27536

…#27536) PR Close angular#27536

…ngular#27536) cli is not yet officially compatible with typescript 3.2, so we need to disable the version check via: ng config cli.warnings.typescriptMismatch false PR Close angular#27536

…mpilerOptions (angular#27536) We need to do this because we don't yet have a released version of angular with typescript 3.2 support and on CI we test both against the snapshot and whatever is in aio/yarn.lock. Once we have the next rc or a stable relase we should be able to remove this flag. PS: I also removed the preserveWhitespace:false because that's the default now. PR Close angular#27536

angular-automatic-lock-bot · 2019-09-14T12:23:19Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Dec 7, 2018

IgorMinar force-pushed the build/typescript-3.2 branch from 0f86dfc to 3ff3b65 Compare December 7, 2018 07:11

IgorMinar added state: WIP target: major This PR is targeted for the next major release labels Dec 7, 2018

devversion reviewed Dec 7, 2018

View reviewed changes

package.json Show resolved Hide resolved

IgorMinar mentioned this pull request Dec 7, 2018

fix(bazel): tsickle dependency not working with typescript 3.1.x #27402

Closed

IgorMinar force-pushed the build/typescript-3.2 branch from 3ff3b65 to 42d7176 Compare December 13, 2018 06:25

IgorMinar force-pushed the build/typescript-3.2 branch from 42d7176 to 8d4ba41 Compare December 13, 2018 06:59

IgorMinar force-pushed the build/typescript-3.2 branch from d784ba0 to ff0edd5 Compare December 14, 2018 15:52

IgorMinar force-pushed the build/typescript-3.2 branch from ff0edd5 to f5a6d4c Compare December 14, 2018 23:47

IgorMinar force-pushed the build/typescript-3.2 branch from f5a6d4c to 1530a94 Compare December 14, 2018 23:53

IgorMinar requested a review from alxhub December 15, 2018 01:04

IgorMinar added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Dec 15, 2018

alxhub approved these changes Dec 15, 2018

View reviewed changes

alxhub reviewed Dec 15, 2018

View reviewed changes

IgorMinar force-pushed the build/typescript-3.2 branch from d8202f3 to a6e6763 Compare December 15, 2018 01:26

alfaproject reviewed Dec 17, 2018

View reviewed changes

IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Dec 18, 2018

mhevery closed this in 17e702b Dec 18, 2018

mhevery pushed a commit that referenced this pull request Dec 18, 2018

build(docs-infra): update dgeni and dgeni-packages to latest (#27536)

999bd5b

PR Close #27536

IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018

build(docs-infra): update dgeni and dgeni-packages to latest (angular…

d0eb83a

…#27536) PR Close angular#27536

IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018

build(docs-infra): update dgeni and dgeni-packages to latest (angular…

6f66918

…#27536) PR Close angular#27536

ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019

build(docs-infra): update dgeni and dgeni-packages to latest (angular…

3f699b7

…#27536) PR Close angular#27536

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for typescript 3.2 #27536

feat: add support for typescript 3.2 #27536

IgorMinar commented Dec 7, 2018

mary-poppins commented Dec 7, 2018

mary-poppins commented Dec 7, 2018

mary-poppins commented Dec 13, 2018

mary-poppins commented Dec 13, 2018

mary-poppins commented Dec 13, 2018

mary-poppins commented Dec 14, 2018

mary-poppins commented Dec 14, 2018

mary-poppins commented Dec 14, 2018

mary-poppins commented Dec 15, 2018

alxhub Dec 15, 2018

mary-poppins commented Dec 15, 2018

IgorMinar commented Dec 15, 2018

mary-poppins commented Dec 17, 2018

alfaproject Dec 17, 2018

IgorMinar Dec 18, 2018

IgorMinar commented Dec 18, 2018

zw-slime commented Jan 9, 2019

IgorMinar commented Jan 9, 2019 via email

angular-automatic-lock-bot bot commented Sep 14, 2019

feat: add support for typescript 3.2 #27536

feat: add support for typescript 3.2 #27536

Conversation

IgorMinar commented Dec 7, 2018

mary-poppins commented Dec 7, 2018

mary-poppins commented Dec 7, 2018

mary-poppins commented Dec 13, 2018

mary-poppins commented Dec 13, 2018

mary-poppins commented Dec 13, 2018

mary-poppins commented Dec 14, 2018

mary-poppins commented Dec 14, 2018

mary-poppins commented Dec 14, 2018

mary-poppins commented Dec 15, 2018

alxhub Dec 15, 2018

Choose a reason for hiding this comment

mary-poppins commented Dec 15, 2018

IgorMinar commented Dec 15, 2018

mary-poppins commented Dec 17, 2018

alfaproject Dec 17, 2018

Choose a reason for hiding this comment

IgorMinar Dec 18, 2018

Choose a reason for hiding this comment

IgorMinar commented Dec 18, 2018

zw-slime commented Jan 9, 2019

IgorMinar commented Jan 9, 2019 via email

angular-automatic-lock-bot bot commented Sep 14, 2019