-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng-for and ng-if break with transformer generated change detectors #2984
Comments
The actual issue: The DOM adapter used by the compiler used in the DirectiveProcessor transformer incorrectly reflects on the elements. The adapter cannot detect properly what properties a DOM element has. This problem manifests via change detection. |
Is anyone tackling this? @tbosch mentioned something about registering a Schema last week. |
@matanlurey we'll figure out a plan today. It looks like providing a schema would be a proper solution, but it may take some time. We may have to provide a temporary solution to unblock @jakemac53. |
Assigned to @tbosch as he is already looking into the reflection issue. |
…nsformer. Right now, we always return true until we have property schema support (angular#2014). Fixes angular#2984 Closes angular#2981
Have a PR up, should go in today. |
…nsformer. Right now, we always return true until we have property schema support (angular#2014). Fixes angular#2984 Closes angular#2981
Verified on 97ef1c2 with Dartium. Awesome! 🤘 |
👍 looks good thanks guys. |
todomvc works with the transformer now as well :) |
…nsformer. Right now, we always return true until we have property schema support (angular#2014). Fixes angular#2984 Closes angular#2981
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
#2981 provides a test which fails. https://gist.github.com/jakemac53/675fdedad5ce469d292f is an simple example which will fail under the transformer.
The text was updated successfully, but these errors were encountered: