Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng-for and ng-if break with transformer generated change detectors #2984

Closed
jakemac53 opened this issue Jul 10, 2015 · 9 comments
Closed

ng-for and ng-if break with transformer generated change detectors #2984

jakemac53 opened this issue Jul 10, 2015 · 9 comments
Assignees
Milestone

Comments

@jakemac53
Copy link
Contributor

#2981 provides a test which fails. https://gist.github.com/jakemac53/675fdedad5ce469d292f is an simple example which will fail under the transformer.

@vsavkin
Copy link
Contributor

vsavkin commented Jul 10, 2015

The actual issue:

The DOM adapter used by the compiler used in the DirectiveProcessor transformer incorrectly reflects on the elements. The adapter cannot detect properly what properties a DOM element has. This problem manifests via change detection.

@vsavkin vsavkin added this to the alpha-32 milestone Jul 10, 2015
@vsavkin vsavkin removed their assignment Jul 10, 2015
@matanlurey
Copy link
Contributor

Is anyone tackling this? @tbosch mentioned something about registering a Schema last week.

@vsavkin
Copy link
Contributor

vsavkin commented Jul 13, 2015

@matanlurey we'll figure out a plan today. It looks like providing a schema would be a proper solution, but it may take some time. We may have to provide a temporary solution to unblock @jakemac53.

@yjbanov
Copy link
Contributor

yjbanov commented Jul 13, 2015

Assigned to @tbosch as he is already looking into the reflection issue.

tbosch added a commit to tbosch/angular that referenced this issue Jul 13, 2015
…nsformer.

Right now, we always return true until
we have property schema support (angular#2014).

Fixes angular#2984
Closes angular#2981
@tbosch
Copy link
Contributor

tbosch commented Jul 13, 2015

Have a PR up, should go in today.

tbosch added a commit to tbosch/angular that referenced this issue Jul 13, 2015
…nsformer.

Right now, we always return true until
we have property schema support (angular#2014).

Fixes angular#2984
Closes angular#2981
@tbosch tbosch modified the milestone: alpha-32 Jul 13, 2015
@tbosch tbosch closed this as completed in b3a763a Jul 13, 2015
@kevmoo
Copy link
Contributor

kevmoo commented Jul 14, 2015

Verified on 97ef1c2 with Dartium. Awesome! 🤘

@matanlurey
Copy link
Contributor

👍 looks good thanks guys.

@jakemac53
Copy link
Contributor Author

todomvc works with the transformer now as well :)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants