Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel schematic builds prod bundle for ng test #30191

Closed
alexeagle opened this issue Apr 29, 2019 · 2 comments
Closed

bazel schematic builds prod bundle for ng test #30191

alexeagle opened this issue Apr 29, 2019 · 2 comments
Assignees
Labels
area: bazel Issues related to the published `@angular/bazel` build rules freq3: high type: bug/fix
Milestone

Comments

@alexeagle
Copy link
Contributor

ng test should just run the unit tests, not run rollup and terser to bundle the production app.

(this happens because we do bazel test //src/... which also builds all the buildable things. Adding tags=['manual'] on targets that are only needed for production is one way to solve it)

@alexeagle alexeagle added type: bug/fix freq3: high severity1: confusing area: bazel Issues related to the published `@angular/bazel` build rules labels Apr 29, 2019
@ngbot ngbot bot added this to the Backlog milestone Apr 29, 2019
@alexeagle
Copy link
Contributor Author

Even simpler fix is for the "test" builder to have "options: { "targetLabel": "//src/app/..." } so it skips all top-level targets. This assumes there aren't any unit tests in the //src package.

@kyliau kyliau self-assigned this May 16, 2019
kyliau added a commit to kyliau/angular that referenced this issue May 16, 2019
kyliau added a commit to kyliau/angular that referenced this issue May 16, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this issue May 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: bazel Issues related to the published `@angular/bazel` build rules freq3: high type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants